[Bug 1124070] Review Request: pcaro-hermit-fonts - Monospace fonts for programming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1124070



--- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Thanks. Few more changes I will suggest

1) We have fedora-review tool which reads the spec and srpm links. This tool
shows issue for spec file name as it will not match to what is packaged inside
srpm. You can have multiple revisions of spec along with version at your web
location but keep only one latest spec with just pcaro-hermit-fonts.spec name.

2) The upstream also uses spelling as "monospace" and not "mono-space". Please
change all such occurrences. Let rpmlint complain it as warning.

3) I think many are familiar with this way to fix DOS line endings
http://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings

4) with your recent changelog another rpmlint warning has come. When you use
character '%' in %changelog section or in any line which is a comment, always
use it as twice '%%' character.


Else looks good now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]