https://bugzilla.redhat.com/show_bug.cgi?id=825409 --- Comment #33 from Rich Mattes <richmattes@xxxxxxxxx> --- Thanks for the review Scott. I've replied to your notes inline (In reply to Scott K Logan from comment #32) > Okay, I've completed the package review. This is a MASSIVE package, and I > applaud your efforts, Rich. Nonetheless, There are a few things that should > be addressed before this package is approved. > > Notes: > - Is there a reason that you are not using the %cmake macro in the %build > section? This will set many of the manually defined cmake variables, > including CMAKE_INSTALL_PREFIX, which should otherwise be %{_prefix}, not > `/usr`. There used to be a reason, but as gazebo evolved it stopped trying to do things like override user-specified cflags. It looks like now it's OK to just use %cmake, so I switched it. > - Any reason not to pass %{?_smp_mflags} to `make doc`? Maybe it can take > advantage of threading... I don't think there's any reason to, but it can't hurt. > - Unversioned .so files are in non-devel package, but these are plugins and > are in a private directory that is not in the ld path, so this is okay. > - There are several bundled fonts in gazebo-media [1]. This should be > addressed. Ugh. I'll try to fix this. > - Gazebo 3.0 has been released. Is there an argument that Fedora 19/20 should > have 2.2 instead? Not really, other than the fact that the required packages aren't all ready yet. Gazebo 3 requires sdformat 2.0 or higher, and the repositories currently have 1.4. I built sdformat 2.0 for f20 and pushed it to updates-testing, and will also do so for f19 and el6. sdformat in rawhide is broken because i update udrdfom to 3.0 which sdformat doesn't support yet. I'm waiting on the bug at https://bitbucket.org/osrf/sdformat/issue/59/embedded-copy-of-urdfdom-is-outdated to be resolved before I can build sdformat 2.0 in rawhide. So that being said, I've got updates here: Spec URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo-3.0.0-1.fc20.src.rpm The font issue is still not addressed, I will keep working on that and post it when it's ready. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review