[Bug 1098625] Review Request: php-pear-Text-Wiki - Transforms Wiki and BBCode markup into XHTML, LaTeX or plain text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1098625



--- Comment #5 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #4)
> > So this seems a copy/paste/cleanup minor error.
> > So I think correct License is really LGPLv2.
> > 
> > But we can wait a little for upstream feedback if you prefer.

https://github.com/pear/Text_Wiki/pull/2

This PR fix the need for clarification.

> 
> It really seems as error. Meantime we should wait answer or may fire Legal
> flag now.
> 
> > > 2)
> > > [!]: Package does not own files or directories owned by other packages.
> > >      Note: Dirs in package are owned also by:
> > > /usr/share/pear/Text(php-phpunit-Text-Template)
> > 
> > php-phpunit-Text-Template is not required, so this is ok.
> No, it is not ok. Then it should be used for directory presence, item:
> [x]: Package requires other packages for directories it uses.
> i have marked as Ok, but we can look at it in that angle.
> 
> > Also notice that Text_Template have now moved to /usr/share/php  (in
> > rawhide).
> Do you target your package only for rawhide?

No, also stable branch.

Guidelines seems clear.

"MUST: A package must own all directories that it creates."

=> So it owns /usr/share/php/Text

"If it does not create a directory that it uses, then it should require a
package which does create that directory."

=> It creates it.

"MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time."

=> This package can be install alone, no need of Text_Template, so need to
create and own this directory
=> Text_Template can be install alone, no need of this package, so need to
create and own this directory

So both have to create and own this folder.
Look at  /usr/share/pear/Net, this is quite common.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]