https://bugzilla.redhat.com/show_bug.cgi?id=825409 --- Comment #32 from Scott K Logan <logans@xxxxxxxxxxx> --- Okay, I've completed the package review. This is a MASSIVE package, and I applaud your efforts, Rich. Nonetheless, There are a few things that should be addressed before this package is approved. Notes: - Is there a reason that you are not using the %cmake macro in the %build section? This will set many of the manually defined cmake variables, including CMAKE_INSTALL_PREFIX, which should otherwise be %{_prefix}, not `/usr`. - Any reason not to pass %{?_smp_mflags} to `make doc`? Maybe it can take advantage of threading... - Unversioned .so files are in non-devel package, but these are plugins and are in a private directory that is not in the ld path, so this is okay. - There are several bundled fonts in gazebo-media [1]. This should be addressed. - Gazebo 3.0 has been released. Is there an argument that Fedora 19/20 should have 2.2 instead? Thanks, --scott [1] http://fedoraproject.org/wiki/Packaging:FontsPolicy Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "BSL (v1.0)", "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated", "BSD (3 clause)". 283 files have unknown license. Detailed output of licensecheck in /home/cottsay/825409-gazebo/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in gazebo [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gazebo- media , gazebo-doc [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [?]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gazebo-2.2.1-2.fc20.x86_64.rpm gazebo-devel-2.2.1-2.fc20.x86_64.rpm gazebo-media-2.2.1-2.fc20.noarch.rpm gazebo-playerplugin-2.2.1-2.fc20.x86_64.rpm gazebo-doc-2.2.1-2.fc20.noarch.rpm gazebo-2.2.1-2.fc20.src.rpm gazebo.x86_64: W: spelling-error Summary(en_US) multi -> mulch, mufti gazebo.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti gazebo.x86_64: W: shared-lib-calls-exit /usr/lib64/libgazebo_ode.so.2.2.1 exit@GLIBC_2.2.5 gazebo.x86_64: W: no-manual-page-for-binary gzfactory-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzstats-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzserver-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gztopic-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzsdf-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gazebo-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzlog-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzmodel_create gazebo.x86_64: W: no-manual-page-for-binary gzclient-2.2.1 gazebo-devel.x86_64: W: no-documentation gazebo-media.noarch: W: no-documentation gazebo-media.noarch: W: dangling-symlink /usr/share/gazebo-2.2/media/skyx /usr/share/SKYX/Media/SkyX gazebo-playerplugin.x86_64: W: no-documentation gazebo.src: W: spelling-error Summary(en_US) multi -> mulch, mufti gazebo.src: W: spelling-error %description -l en_US multi -> mulch, mufti 6 packages and 0 specfiles checked; 0 errors, 18 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gazebo-doc gazebo-media gazebo gazebo-playerplugin gazebo-devel gazebo-media.noarch: W: no-documentation gazebo-media.noarch: W: dangling-symlink /usr/share/gazebo-2.2/media/skyx /usr/share/SKYX/Media/SkyX gazebo.x86_64: W: spelling-error Summary(en_US) multi -> mulch, mufti gazebo.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti ... gazebo.x86_64: W: unused-direct-shlib-dependency ...MANY OF THESE ... gazebo.x86_64: W: undefined-non-weak-symbol ...MANY OF THESE ... gazebo.x86_64: W: unused-direct-shlib-dependency ... gazebo.x86_64: W: no-manual-page-for-binary gzfactory-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzstats-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzserver-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gztopic-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzsdf-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gazebo-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzlog-2.2.1 gazebo.x86_64: W: no-manual-page-for-binary gzmodel_create gazebo.x86_64: W: no-manual-page-for-binary gzclient-2.2.1 gazebo-playerplugin.x86_64: W: no-documentation gazebo-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 1355 warnings. # echo 'rpmlint-done:' Requires -------- gazebo-doc (rpmlib, GLIBC filtered): gazebo gazebo-media (rpmlib, GLIBC filtered): SkyX gazebo gazebo (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env gazebo-media ld-linux-x86-64.so.2()(64bit) libCEGUIBase-0.7.9.so()(64bit) libCEGUIOgreRenderer-0.7.9.so()(64bit) libForceTorquePlugin.so()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libOgreMain.so.1.8.1()(64bit) libOgrePaging.so.1.8.1()(64bit) libOgreRTShaderSystem.so.1.8.1()(64bit) libOgreTerrain.so.1.8.1()(64bit) libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libSM.so.6()(64bit) libSkyX.so.0()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libboost_date_time.so.1.54.0()(64bit) libboost_filesystem.so.1.54.0()(64bit) libboost_iostreams.so.1.54.0()(64bit) libboost_program_options.so.1.54.0()(64bit) libboost_regex.so.1.54.0()(64bit) libboost_signals.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libboost_thread.so.1.54.0()(64bit) libc.so.6()(64bit) libccd.so.2()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libfreeimage.so.3()(64bit) libgazebo.so.2()(64bit) libgazebo_common.so.2()(64bit) libgazebo_gimpact.so.2()(64bit) libgazebo_gui.so.2()(64bit) libgazebo_gui_building.so.2()(64bit) libgazebo_gui_viewers.so.2()(64bit) libgazebo_math.so.2()(64bit) libgazebo_msgs.so.2()(64bit) libgazebo_ode.so.2()(64bit) libgazebo_opcode.so.2()(64bit) libgazebo_opende_ou.so.2()(64bit) libgazebo_physics.so.2()(64bit) libgazebo_physics_ode.so.2()(64bit) libgazebo_rendering.so.2()(64bit) libgazebo_rendering_deferred.so.2()(64bit) libgazebo_selection_buffer.so.2()(64bit) libgazebo_sensors.so.2()(64bit) libgazebo_transport.so.2()(64bit) libgazebo_util.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglib-2.0.so.0()(64bit) libgts-0.7.so.5()(64bit) libltdl.so.7()(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsdformat.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libtar.so.1()(64bit) libtbb.so.2()(64bit) libtinyxml.so.0()(64bit) rtld(GNU_HASH) gazebo-playerplugin (rpmlib, GLIBC filtered): gazebo(x86-64) gazebo-media libboost_date_time.so.1.54.0()(64bit) libboost_filesystem.so.1.54.0()(64bit) libboost_iostreams.so.1.54.0()(64bit) libboost_program_options.so.1.54.0()(64bit) libboost_regex.so.1.54.0()(64bit) libboost_signals.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libboost_thread.so.1.54.0()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libfreeimage.so.3()(64bit) libgazebo_common.so.2()(64bit) libgazebo_math.so.2()(64bit) libgazebo_msgs.so.2()(64bit) libgazebo_transport.so.2()(64bit) libgazebo_util.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgeos-3.4.2.so()(64bit) libgeos_c.so.1()(64bit) libglib-2.0.so.0()(64bit) libgts-0.7.so.5()(64bit) libltdl.so.7()(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libplayerc++.so.3.0()(64bit) libplayerc.so.3.0()(64bit) libplayercommon.so.3.0()(64bit) libplayercore.so.3.0()(64bit) libplayerinterface.so.3.0()(64bit) libplayerwkb.so.3.0()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsdformat.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtar.so.1()(64bit) libtbb.so.2()(64bit) libtinyxml.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gazebo-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cegui-devel freeimage-devel gazebo(x86-64) gazebo-media libgazebo.so.2()(64bit) libgazebo_common.so.2()(64bit) libgazebo_gimpact.so.2()(64bit) libgazebo_gui.so.2()(64bit) libgazebo_gui_building.so.2()(64bit) libgazebo_gui_viewers.so.2()(64bit) libgazebo_math.so.2()(64bit) libgazebo_msgs.so.2()(64bit) libgazebo_ode.so.2()(64bit) libgazebo_opcode.so.2()(64bit) libgazebo_opende_ou.so.2()(64bit) libgazebo_physics.so.2()(64bit) libgazebo_physics_ode.so.2()(64bit) libgazebo_rendering.so.2()(64bit) libgazebo_rendering_deferred.so.2()(64bit) libgazebo_selection_buffer.so.2()(64bit) libgazebo_sensors.so.2()(64bit) libgazebo_transport.so.2()(64bit) libgazebo_util.so.2()(64bit) protobuf-devel sdformat-devel tbb-devel Provides -------- gazebo-doc: gazebo-doc gazebo-media: gazebo-media gazebo: application() application(gazebo.desktop) gazebo gazebo(x86-64) libBreakableJointPlugin.so()(64bit) libCameraPlugin.so()(64bit) libCartTestPlugin.so()(64bit) libContactPlugin.so()(64bit) libDepthCameraPlugin.so()(64bit) libDiffDrivePlugin.so()(64bit) libForceTorquePlugin.so()(64bit) libGpuRayPlugin.so()(64bit) libJointTrajectoryPlugin.so()(64bit) libModelPropShop.so()(64bit) libModelTrajectoryTestPlugin.so()(64bit) libMudPlugin.so()(64bit) libPressurePlugin.so()(64bit) libRayPlugin.so()(64bit) libRubblePlugin.so()(64bit) libSkidSteerDrivePlugin.so()(64bit) libSonarPlugin.so()(64bit) libSphereAtlasTestPlugin.so()(64bit) libSpringTestPlugin.so()(64bit) libVehiclePlugin.so()(64bit) libgazebo.so.2()(64bit) libgazebo_common.so.2()(64bit) libgazebo_gimpact.so.2()(64bit) libgazebo_gui.so.2()(64bit) libgazebo_gui_building.so.2()(64bit) libgazebo_gui_viewers.so.2()(64bit) libgazebo_math.so.2()(64bit) libgazebo_msgs.so.2()(64bit) libgazebo_ode.so.2()(64bit) libgazebo_opcode.so.2()(64bit) libgazebo_opende_ou.so.2()(64bit) libgazebo_physics.so.2()(64bit) libgazebo_physics_ode.so.2()(64bit) libgazebo_rendering.so.2()(64bit) libgazebo_rendering_deferred.so.2()(64bit) libgazebo_selection_buffer.so.2()(64bit) libgazebo_sensors.so.2()(64bit) libgazebo_transport.so.2()(64bit) libgazebo_util.so.2()(64bit) gazebo-playerplugin: gazebo-playerplugin gazebo-playerplugin(x86-64) libgazebo_player.so.2()(64bit) gazebo-devel: gazebo-devel gazebo-devel(x86-64) pkgconfig(gazebo) pkgconfig(gazebo_ode) pkgconfig(gazebo_transport) Unversioned so-files -------------------- gazebo: /usr/lib64/gazebo-2.2/plugins/libBreakableJointPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libCameraPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libCartTestPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libContactPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libDepthCameraPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libDiffDrivePlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libForceTorquePlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libGpuRayPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libJointTrajectoryPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libModelPropShop.so gazebo: /usr/lib64/gazebo-2.2/plugins/libModelTrajectoryTestPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libMudPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libPressurePlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libRayPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libRubblePlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libSkidSteerDrivePlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libSonarPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libSphereAtlasTestPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libSpringTestPlugin.so gazebo: /usr/lib64/gazebo-2.2/plugins/libVehiclePlugin.so gazebo-playerplugin: /usr/lib64/player/libgazebo_player.so Source checksums ---------------- http://gazebosim.org/assets/distributions/gazebo-2.2.1.tar.bz2 : CHECKSUM(SHA256) this package : 153ad233159ccb8426481ec81859bc6ad6419872bc8389c3cf9b19f4a117da02 CHECKSUM(SHA256) upstream package : 153ad233159ccb8426481ec81859bc6ad6419872bc8389c3cf9b19f4a117da02 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 825409 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review