[Bug 1094864] Review Request: php-pecl-xmldiff - Pecl package for XML diff and merge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1094864



--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> ---
(In reply to Remi Collet from comment #7)
> (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #6)
> You can conditionalize it (which make easier to detect when could be dropped)
> %if 0%{?fedora} < 20 && 0%{?rhel} < 7
That was already stated in comment, but let it be if you insist.

> > mv {CREDITS,LICENSE} ./%{pecl_docdir}/
> > %doc %peclName-%{version}/%{pecl_docdir}/{CREDITS,LICENSE}
> 
> This result as
> /usr/share/doc/php-pecl-xmldiff
> /usr/share/doc/php-pecl-xmldiff/CREDITS
> /usr/share/doc/php-pecl-xmldiff/LICENSE
> 
> While expected is (check: "pecl list xmldiff")
> /usr/share/doc/pecl/xmldiff
> /usr/share/doc/pecl/xmldiff/CREDITS
> /usr/share/doc/pecl/xmldiff/LICENSE
Interesting it is because it is marked as %doc:

+ cd /home/pasha/SOFT/rpmbuild/BUILD
+ cd php-pecl-xmldiff-0.9.2
+
DOCDIR=/home/pasha/SOFT/rpmbuild/BUILDROOT/php-pecl-xmldiff-0.9.2-2.fc20.x86_64/usr/share/doc/php-pecl-xmldiff
+ export DOCDIR
+ /usr/bin/mkdir -p
/home/pasha/SOFT/rpmbuild/BUILDROOT/php-pecl-xmldiff-0.9.2-2.fc20.x86_64/usr/share/doc/php-pecl-xmldiff
+ cp -pr xmldiff-0.9.2//usr/share/doc/pecl/xmldiff/CREDITS
xmldiff-0.9.2//usr/share/doc/pecl/xmldiff/LICENSE
/home/pasha/SOFT/rpmbuild/BUILDROOT/php-pecl-xmldiff-0.9.2-2.fc20.x86_64/usr/share/doc/php-pecl-xmldiff

Do you suggest not mark it as %doc and include as just files?
Then I think we violate documentation rules:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Documentation
. One more way is try redefine DOCDIR environment variable in spec, but it also
looks not so correct for me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]