[Bug 1094864] Review Request: php-pecl-xmldiff - Pecl package for XML diff and merge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1094864



--- Comment #7 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #6)
> >- filtering private is no more needed in f20+ (and rhel7)
> Obviously i've missing something. Where it stated? Meantime if it is not
> targeted to El5 i'm prefer leave it for Fedora 19.

You can conditionalize it (which make easier to detect when could be dropped)
%if 0%{?fedora} < 20 && 0%{?rhel} < 7

> 
> >- why don't you provide the -devel sub package ? (with the installed header, and perhaps the upstream test suite... useful as documentation)
> I don't know anything which may use it, do you? Is it have worth at all?

I don't know anything which use it yet.  
I'm used to follow upstream desing.
But will be easy to fix if needed later...
Your choice.

> mv {CREDITS,LICENSE} ./%{pecl_docdir}/
> %doc %peclName-%{version}/%{pecl_docdir}/{CREDITS,LICENSE}

This result as
/usr/share/doc/php-pecl-xmldiff
/usr/share/doc/php-pecl-xmldiff/CREDITS
/usr/share/doc/php-pecl-xmldiff/LICENSE

While expected is (check: "pecl list xmldiff")
/usr/share/doc/pecl/xmldiff
/usr/share/doc/pecl/xmldiff/CREDITS
/usr/share/doc/pecl/xmldiff/LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]