https://bugzilla.redhat.com/show_bug.cgi?id=1091755 David King <amigadave@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |amigadave@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |amigadave@xxxxxxxxxxxxx Flags| |fedora-review+ --- Comment #3 from David King <amigadave@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines I guess that once Rawhide composes later today (with the updated vte3) this will disappear. - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions This is bogus, as the setgid bit on gnome-pty-helper is necessary. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2.1 or later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 22 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/1091755-compat- vte036/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/girepository-1.0 (gobject-introspection, libxklavier, GConf2, libgnome-keyring, gdk- pixbuf2, libgtop2, libgee06, atk, gtk2, gtk3, vte3, gcr, libgee, gfbgraph, libzapojit, gucharmap, libmash), /usr/lib64/vte-2.90(vte3) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.1.38 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.38 INFO: Mock Version: 1.1.38 Start: lock buildroot INFO: installing package(s): /home/david/checkout/rpms/1091755-compat-vte036/results/compat-vte036-0.36.1-2.fc21.x86_64.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', '--releasever', '21', 'install', '/home/david/checkout/rpms/1091755-compat-vte036/results/compat-vte036-0.36.1-2.fc21.x86_64.rpm', '--setopt=tsflags=nocontexts'] ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: compat-vte036 x86_64 0.36.1-2.fc21 /compat-vte036-0.36.1-2.fc21.x86_64 942 k Installing for dependencies: acl x86_64 2.2.52-4.fc21 fedora 70 k adwaita-icon-theme noarch 3.13.1-1.fc21 fedora 10 M at-spi2-atk x86_64 2.13.1-1.fc21 fedora 78 k at-spi2-core x86_64 2.13.1-1.fc21 fedora 155 k atk x86_64 2.12.0-2.fc21 fedora 248 k avahi-libs x86_64 0.6.31-25.fc21 fedora 56 k cairo x86_64 1.13.1-0.1.git337ab1f.fc21 fedora 701 k cairo-gobject x86_64 1.13.1-0.1.git337ab1f.fc21 fedora 24 k colord-libs x86_64 1.2.0-1.fc21 fedora 165 k cryptsetup-libs x86_64 1.6.4-2.fc21 fedora 174 k cups-libs x86_64 1:1.7.2-2.fc21 fedora 370 k dbus x86_64 1:1.6.18-3.fc21 fedora 305 k dbus-libs x86_64 1:1.6.18-3.fc21 fedora 149 k device-mapper x86_64 1.02.85-3.fc21 fedora 205 k device-mapper-libs x86_64 1.02.85-3.fc21 fedora 242 k fipscheck x86_64 1.4.1-4.fc21 fedora 20 k fipscheck-lib x86_64 1.4.1-4.fc21 fedora 9.4 k fontconfig x86_64 2.11.1-2.fc21 fedora 229 k fontpackages-filesystem noarch 1.44-9.fc20 fedora 10 k freetype x86_64 2.5.3-5.fc21 fedora 399 k gdk-pixbuf2 x86_64 2.30.7-1.fc21 fedora 535 k gnutls x86_64 3.3.1-2.fc21 fedora 600 k graphite2 x86_64 1.2.4-1.fc21 fedora 84 k gtk3 x86_64 3.13.1-2.fc21 fedora 3.7 M harfbuzz x86_64 0.9.27-1.fc21 fedora 148 k hicolor-icon-theme noarch 0.13-1.fc21 fedora 42 k hostname x86_64 3.15-1.fc21 fedora 16 k hwdata noarch 0.265-1.fc21 fedora 1.3 M initscripts x86_64 9.54-2.fc21 fedora 400 k iproute x86_64 3.14.0-1.fc21 fedora 516 k iptables x86_64 1.4.21-8.fc21 fedora 419 k iputils x86_64 20121221-10.fc21 fedora 152 k jasper-libs x86_64 1.900.1-25.fc21 fedora 144 k jbigkit-libs x86_64 2.0-10.fc21 fedora 45 k kmod x86_64 17-1.fc21 fedora 106 k kmod-libs x86_64 17-1.fc21 fedora 44 k lcms2 x86_64 2.6-1.fc21 fedora 148 k libX11 x86_64 1.6.1-1.fc21 fedora 595 k libX11-common noarch 1.6.1-1.fc21 fedora 180 k libXau x86_64 1.0.8-2.fc21 fedora 28 k libXcomposite x86_64 0.4.4-4.fc21 fedora 21 k libXcursor x86_64 1.1.14-2.fc21 fedora 28 k libXdamage x86_64 1.1.4-4.fc21 fedora 19 k libXevie x86_64 1.0.3-7.fc21 fedora 17 k libXext x86_64 1.3.2-2.fc21 fedora 36 k libXfixes x86_64 5.0.1-2.fc21 fedora 17 k libXft x86_64 2.3.1-6.fc21 fedora 56 k libXi x86_64 1.7.2-2.fc21 fedora 37 k libXinerama x86_64 1.1.3-2.fc21 fedora 13 k libXrandr x86_64 1.4.1-2.fc21 fedora 24 k libXrender x86_64 0.9.8-2.fc21 fedora 24 k libXtst x86_64 1.2.2-2.fc21 fedora 19 k libXxf86vm x86_64 1.1.3-2.fc21 fedora 16 k libdrm x86_64 2.4.53-1.fc21 fedora 119 k libgudev1 x86_64 212-2.fc21 fedora 46 k libgusb x86_64 0.1.6-2.fc20 fedora 33 k libjpeg-turbo x86_64 1.3.1-2.fc21 fedora 137 k libmicrohttpd x86_64 0.9.34-2.fc21 fedora 57 k libmnl x86_64 1.0.3-6.fc21 fedora 22 k libnetfilter_conntrack x86_64 1.0.4-1.fc21 fedora 51 k libnfnetlink x86_64 1.0.1-3.fc21 fedora 24 k libpciaccess x86_64 0.13.3-0.1.fc21 fedora 25 k libpng x86_64 2:1.6.10-1.fc21 fedora 259 k libseccomp x86_64 2.1.1-2.fc21 fedora 38 k libthai x86_64 0.1.20-1.fc21 fedora 194 k libtiff x86_64 4.0.3-14.fc21 fedora 164 k libusbx x86_64 1.0.18-1.fc21 fedora 57 k libwayland-client x86_64 1.4.0-1.fc21 fedora 25 k libwayland-cursor x86_64 1.4.0-1.fc21 fedora 15 k libwayland-server x86_64 1.4.0-1.fc21 fedora 30 k libxcb x86_64 1.10-1.fc21 fedora 165 k libxkbcommon x86_64 0.4.0-1.fc21 fedora 94 k libxshmfence x86_64 1.1-1.fc21 fedora 5.6 k linux-atm-libs x86_64 2.5.1-8.fc21 fedora 25 k lyx-fonts noarch 2.1.0-0.fc21 fedora 164 k mesa-libEGL x86_64 10.1.1-2.20140419.fc21 fedora 79 k mesa-libGL x86_64 10.1.1-2.20140419.fc21 fedora 149 k mesa-libgbm x86_64 10.1.1-2.20140419.fc21 fedora 34 k mesa-libglapi x86_64 10.1.1-2.20140419.fc21 fedora 36 k nettle x86_64 2.7.1-3.fc21 fedora 324 k pango x86_64 1.36.3-1.fc21 fedora 282 k pixman x86_64 0.32.0-2.fc21 fedora 255 k procps-ng x86_64 3.3.9-8.fc21 fedora 284 k qrencode-libs x86_64 3.4.2-1.fc21 fedora 49 k systemd x86_64 212-2.fc21 fedora 3.9 M trousers x86_64 0.3.11.2-3.fc21 fedora 281 k vte3 x86_64 0.36.1-1.fc21 fedora 342 k Transaction Summary ================================================================================ Install 1 Package (+87 Dependent packages) Total size: 32 M Total download size: 2.2 M Installed size: 86 M Transaction check error: file /usr/lib64/libvte2_90.so.9.3600.1 conflicts between attempted installs of compat-vte036-0.36.1-2.fc21.x86_64 and vte3-0.36.1-1.fc21.x86_64 file /usr/lib64/vte-2.90/gnome-pty-helper conflicts between attempted installs of compat-vte036-0.36.1-2.fc21.x86_64 and vte3-0.36.1-1.fc21.x86_64 Error Summary ------------- Rpmlint ------- Checking: compat-vte036-0.36.1-2.fc21.x86_64.rpm compat-vte036-0.36.1-2.fc21.src.rpm compat-vte036.x86_64: W: spelling-error Summary(en_US) vte -> vet, vote, vie compat-vte036.x86_64: W: spelling-error %description -l en_US terminfo -> term info, term-info, terminator compat-vte036.x86_64: E: missing-call-to-setgroups /usr/lib64/vte-2.90/gnome-pty-helper compat-vte036.x86_64: E: setgid-binary /usr/lib64/vte-2.90/gnome-pty-helper utmp 02711L compat-vte036.x86_64: E: non-standard-executable-perm /usr/lib64/vte-2.90/gnome-pty-helper 02711L compat-vte036.x86_64: E: non-standard-executable-perm /usr/lib64/vte-2.90/gnome-pty-helper 02711L compat-vte036.src: W: spelling-error Summary(en_US) vte -> vet, vote, vie compat-vte036.src: W: spelling-error %description -l en_US terminfo -> term info, term-info, terminator compat-vte036.src: W: strange-permission vte-0.36.1.tar.xz 0444L 2 packages and 0 specfiles checked; 4 errors, 5 warnings. Requires -------- compat-vte036 (rpmlib, GLIBC filtered): /sbin/ldconfig initscripts libX11.so.6()(64bit) libXext.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libm.so.6()(64bit) libncurses.so.5()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libtinfo.so.5()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) vte3 Provides -------- compat-vte036: compat-vte036 compat-vte036(x86-64) libvte2_90.so.9()(64bit) Source checksums ---------------- http://download.gnome.org/sources/vte/0.36/vte-0.36.1.tar.xz : CHECKSUM(SHA256) this package : 2b1d30d12a9c0074f80938f4bcb0d510cf3f105b28939b0d5aaddf95222bc3dd CHECKSUM(SHA256) upstream package : 2b1d30d12a9c0074f80938f4bcb0d510cf3f105b28939b0d5aaddf95222bc3dd Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1091755 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review