[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080583



--- Comment #8 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
Hi Darryl, I think this one also needs a -doc subpackage. There is a
client-devel-docs but, I think this needs to be addressed as well(?)

- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
  or number of files.
  Note: Documentation size is 19148800 bytes in 1154 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

and this,

- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in compat-qpid-cpp-server
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

Also, I think there are some rpmlint errors that we should address as well.

(1)
compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/qpid-topic-listener ['/builddir/build/BUILD/qpid-0.24/cpp/src', '']
compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/qpid-client-test ['/builddir/build/BUILD/qpid-0.24/cpp/src', '']
compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/qpid-latency-test ['/builddir/build/BUILD/qpid-0.24/cpp/src', '']
compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/qpid-txtest ['/builddir/build/BUILD/qpid-0.24/cpp/src', '']
compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/qpid-topic-publisher ['/builddir/build/BUILD/qpid-0.24/cpp/src', '']
compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/qpid-perftest ['/builddir/build/BUILD/qpid-0.24/cpp/src', '']

(2) E: explicit-lib-dependency libaio

Requires:  libaio under %package server-store

Could you please take a look?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]