[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080583



--- Comment #7 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
(In reply to Darryl L. Pierce from comment #6)
> (In reply to Mukundan Ragavan from comment #3)
> > [!]: Package requires other packages for directories it uses.
> >      Note: No known owner of /usr/libexec/qpid, /usr/lib64/qpid/client,
> >      /usr/lib64/qpid/daemon
> >
> > [!]: Package must own all directories that it creates.
> >      Note: Directories without known owners: /etc/rc.d/init.d,
> >      /usr/lib64/qpid/daemon, /usr/libexec/qpid, /etc/rc.d,
> >      /usr/lib64/qpid/client
> 
> It shouldn't own /etc/rc.d/init.d or /etc/rc.d. Others should be fine.

That would be fine, yes.

> 
> > [!]: Package does not own files or directories owned by other packages.
> 
> See my previous comment about compat-qpid-cpp and qpid-cpp being
> intentionally conflicting packages.
> 

Thanks for the clarification! :)

> > Generic:
> > [!]: Uses parallel make %{?_smp_mflags} macro.
> 
> Not sure why this was flagged, the build does in fact use parallel make
> which is desirable and not a red flag. Is the review tool having some issues?
> 
> > Generic:
> > [!]: Rpmlint is run on all installed packages.
> >      Note: Mock build failed
> >      See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
> > [!]: Package should not use obsolete m4 macros
> >      Note: Some obsoleted macros found, see the attachment.
> >      See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
> 
> The build doesn't use the autotools chain, but uses Cmake.

Yeah - I was also wondering about that....

> 
> Also fixed the Requires for compat packages that were still drawing in
> qpid-cpp packages.
> 
> Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6796076
> Updated spec:  http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp.spec
> Updated SRPM: 
> http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp-0.24-4.fc20.src.rpm

I will try to get this done later this evening.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]