https://bugzilla.redhat.com/show_bug.cgi?id=1080583 --- Comment #9 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to Mukundan Ragavan from comment #8) > Hi Darryl, I think this one also needs a -doc subpackage. There is a > client-devel-docs but, I think this needs to be addressed as well(?) I might be misunderstanding something, but I don't know what "this one" refers to in the above sentence. We have a compat-qpid-cpp-client-devel-doc subpackage that is capturing all of the generated documentation. What other docs are you referring to? > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) > or number of files. > Note: Documentation size is 19148800 bytes in 1154 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation > > and this, > > - ldconfig called in %post and %postun if required. > Note: /sbin/ldconfig not called in compat-qpid-cpp-server > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > > Also, I think there are some rpmlint errors that we should address as well. > > (1) > compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath > /usr/bin/qpid-topic-listener ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] > compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath > /usr/bin/qpid-client-test ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] > compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath > /usr/bin/qpid-latency-test ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] > compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath > /usr/bin/qpid-txtest ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] > compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath > /usr/bin/qpid-topic-publisher ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] > compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath > /usr/bin/qpid-perftest ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] Very strange here. CMake usually has the rpath problem if you use install(files) rather than install(targets), with the latter case stripping the data as expected. So to fix this I've added -DCMAKE_SKIP_RPATH:BOOL=ON to the build and the rpath information isn't getting created at all now. > (2) E: explicit-lib-dependency libaio > > Requires: libaio under %package server-store > > Could you please take a look? Fixed thi sas well. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6806842 Updated spec: http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp.spec Updated srpm: http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp-0.24-5.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review