Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235815 Summary: Review Request: freetennis - Tennis simulation game Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@xxxxxxxxxxxxxxxxx ReportedBy: dev@xxxxxxxxxx QAContact: fedora-package-review@xxxxxxxxxx Spec URL: http://dev.nigelj.com/SRPMS/freetennis.spec SRPM URL: http://dev.nigelj.com/SRPMS/freetennis-0.4.8-1.src.rpm Description: Free Tennis is a free software tennis simulation game. The game can be played against an A.I. or human-vs-human via LAN or internet. rpmlint is clean on all rpms (incl src). Potential problems that I'm aware of that may/may not need fixing: 1. As noted in both blockers to this, the game has a buildrequires on -devel packages, but after build does not require library files, I am not sure if I have done something in error, (i.e. the libraries are been statically built), or this is how ocaml treat libraries etc, I've noted that the Debian freetennis package does not require ocamlSDL or camlimages 2. I'm a bit worried if I went a bit OTT on the directory ownership. 3. README and LICENSE are duplicated in both the main package and -data, this is because -data may be used in another package, and it may be possible to provide a seperate datafile, using the same directory format. 4. I think the summaries need a touch up before importing into Fedora, but I have time because this can be even uploaded (due to the blocking Reviews). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review