Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freetennis - Tennis simulation game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235815 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx OtherBugsDependingO|163776 | nThis| | Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-05-04 04:03 EST ------- MUST: ===== * rpmlint output is clean * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel i386 * BR: ok * No locales * No shared libraries, ldconfig not needed * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * -devel package as needed * no .desktop file needed MUST FIX ======== * Change Source0 to the generic sf download url, and use %{version} * Change "Categories=Game" to "Categories=Game;SportsGame;" in the .desktop file, so that it will show up under the Games->"Sport Games" submenu for people who have the games-menus package installed (try it). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review