https://bugzilla.redhat.com/show_bug.cgi?id=1083941 --- Comment #16 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Han Frederic from comment #15) > For 2. I have added those %dir but I wonder why not those 2: > (I have tried with and without them and I didn't see complains in both cases. > (neither system-dir nor shared warning) > #%dir %{_datadir}/applications > #%dir %{_datadir}/pixmaps %{_datadir}/applications and %{_datadir}/pixmaps are owned by a main system package (filesystem). Your package doesn't need to own them. Verify with command: yum provides /usr/share/pixmaps /usr/share/applications > > Where can I find the list of system-dir that must not be included. > (Ex: it is not clear for me why /usr/share/icons gave me the system-dir > error and not /usr/share/applications) /usr/share/icons is not in the review log (comment#14) and should not be owned by your package. Not even /usr/share/mime and /usr/share/mime/packages. Sorry, I had not noted the latter ones. > > Did 3. but need to modify configure/makefiles and regenerate Should not be so. ABOUT-NLS file says: >By default, this package will be installed to allow translation of >messages. It will automatically detect whether the system already >provides the GNU `gettext' functions. If not, the included GNU >`gettext' library will be used. This library is wholly contained >within this package, usually in the `intl/' subdirectory, so prior >installation of the GNU `gettext' package is _not_ required. Therefore, you just need: %prep ... rm -rf intl/*.h rm -rf intl/*.c %build %configure --enable-static=0 --with-included-gettext=no --enable-nls ... > > About 5. I removed the extra +x, and add a warning about the .xws Indeed, > they are not text files, they are saved examples from xcas and any uft8 > conversion will give a mess. Is there some way to mark them as non text > files to avoid those warning? > All the best. I think we can just ignore all file-not-utf8 warnings ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review