[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1072054



--- Comment #7 from Kalev Lember <kalevlember@xxxxxxxxx> ---
> License:        GPLv2+

I think this should be GPLv3+ instead. Some code files are GPLv2+, some are
GPLv3+, and some are MIT.

Also, something for upstream: a bunch of code files are missing license headers
altogether; would be great if upstream could add these. And the COPYING that's
shipped is for LGPL, even though the code files (those that have headers) seem
to be GPL.

> URL:            http://gnome.org

http://wiki.gnome.org/Projects/CodeAssistance

> Source0:        http://ftp.acc.umu.se/pub/GNOME/sources/gnome-code-assistance/0.3/%{name}-%{version}.tar.xz

Would be better to use download.gnome.org instead of the acc.umu.se mirror.
https://download.gnome.org/sources/gnome-code-assistance/0.3/gnome-code-assistance-0.3.1.tar.xz

> %files
> %{_datadir}/dbus-1/services/*.service

Should have Requires: dbus for both the directory ownership and because the
service just doesn't work without it. Not sure how the kdbus plans are going to
affect this in the future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]