https://bugzilla.redhat.com/show_bug.cgi?id=1066176 --- Comment #7 from Colin Walters <walters@xxxxxxxxxx> --- (In reply to Matthew Miller from comment #6) > I hate to be picky, but the command in the spec comment should have the tag > or commit that matches the version in the tarball. The goal is that someone > should be able to create the exact same thing independently for > verification, not just as a convenience for updating. Being picky is good! Particularly so I can show you how I do things, and you'll be better able to understand the model when I get around to some proposals for changes on the Fedora/RPM source side. So the source tarball name with "Makefile.dist-packaging" is always named after a variant of "git describe". In this case, the tarball is being built from a tag named "v2014.1", so the version is just 2014.1. If I make a tarball from a later commit, it looks like this: ostree-2014.1.36.gb762c2f.tar.xz That means we're 36 commits after the tag 2014.1, and the commit is "b762c2f". > And I also hate to be difficult about the changelog, but that's a "must" > item in the packaging guidelines. For now... =) > Can you make the forked package for > inclusion in Fedora at this point? That's what's supposed to be being > reviewed, in any case. Sure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review