[Bug 1066176] Review Request: min-metadata-service - Client for EC2/OpenStack metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1066176



--- Comment #6 from Matthew Miller <mattdm@xxxxxxxxxx> ---
I hate to be picky, but the command in the spec comment should have the tag or
commit that matches the version in the tarball. The goal is that someone should
be able to create the exact same thing independently for verification, not just
as a convenience for updating.

And I also hate to be difficult about the changelog, but that's a "must" item
in the packaging guidelines. Can you make the forked package for inclusion in
Fedora at this point? That's what's supposed to be being reviewed, in any case.

Those points aside, the actual thing looks good, so I'll pass the review as
soon as it's available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]