https://bugzilla.redhat.com/show_bug.cgi?id=1064995 --- Comment #5 from Paul Howarth <paul@xxxxxxxxxxxx> --- (In reply to Ralf Corsepius from comment #4) > (In reply to Paul Howarth from comment #3) > > > - %build section should likely use %{__perl} instead of perl > > > > The guidelines generally discourage the use of macros for commands except > > where there's a need for the command path to be configurable, and cites > > %{__python} as an example. In Fedora there have been parallel python2 and > > python3 stacks so that might seem a reasonable example but Fedora has never > > shipped more than one version of perl and so there's not really a need for > > configurability here. So I prefer the tidier, shorter version. > I have always been in favor of "%perl" and consider package which are using > perl to be sloppily maintainedd, because it > a) is an absolute path, which avoids picking up an arbitrary "perl" in > $PATH, and thus improves deterministic builds I agree with this but FPC clearly don't care about this because the guidelines discourage the use of macros for commands generally (e.g. "%__cp", "%__mv"), in favour of unadorned commands. It's a bit pointless doing this for some commands but not all. > b) the possibility for fedora to ship another perl >> 0 (Perl6, Scls). Mechanisms for achieving these have yet to be determined, and quite possibly would not involve the %__perl macro. For instance, the dual python stacks in Fedora are handled using separate %__python2 and %__python3 macros rather than redefining %__python. Note that I'm playing Devil's Advocate here. I don't have a strong opinion on it either way, and am open to using %__perl; I just don't really see the point of it with the guidelines as they are. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review