https://bugzilla.redhat.com/show_bug.cgi?id=1064995 --- Comment #3 from Paul Howarth <paul@xxxxxxxxxxxx> --- > - %build section should likely use %{__perl} instead of perl The guidelines generally discourage the use of macros for commands except where there's a need for the command path to be configurable, and cites %{__python} as an example. In Fedora there have been parallel python2 and python3 stacks so that might seem a reasonable example but Fedora has never shipped more than one version of perl and so there's not really a need for configurability here. So I prefer the tidier, shorter version. > - rm -rf %{buildroot} is no longer necessary > - BuildRoot tag is unnecessary > - %clean section is unnecessary These are included for EPEL-5 compatibility, which I care about, and are harmless elsewhere. Thanks for taking a look at the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review