https://bugzilla.redhat.com/show_bug.cgi?id=1064579 David King <amigadave@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |amigadave@xxxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from David King <amigadave@xxxxxxxxxxxxx> --- Looks great to me! 4.70.0 is the latest upstream release, is there any chance of using that instead? I have posted a patch to update the native packaging in bug 1047707. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable Issues: ======= - Header files in -devel subpackage, if present. Note: mingw32-wavpack : /usr/i686-w64-mingw32/sys- root/mingw/include/wavpack/wavpack.h mingw64-wavpack : /usr/x86_64-w64-mingw32/sys-root/mingw/include/wavpack/wavpack.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages Not a problem for mingw packages. - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: mingw32-wavpack, mingw64-wavpack. Illegal package name: mingw32-wavpack, mingw64-wavpack. Does not provide -static: mingw32-wavpack, mingw64-wavpack. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries Not really static archives. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Public domain". 22 files have unknown license. Detailed output of licensecheck in /home/david/1064579 -mingw-wavpack/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-wavpack , mingw32-wavpack-tools , mingw64-wavpack , mingw64 -wavpack-tools [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. Note: mingw32-wavpack : /usr/i686-w64-mingw32/sys- root/mingw/lib/pkgconfig/wavpack.pc mingw64-wavpack : /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/wavpack.pc [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-wavpack-4.60.1-1.fc20.noarch.rpm mingw32-wavpack-tools-4.60.1-1.fc20.noarch.rpm mingw64-wavpack-4.60.1-1.fc20.noarch.rpm mingw64-wavpack-tools-4.60.1-1.fc20.noarch.rpm mingw-wavpack-4.60.1-1.fc20.src.rpm mingw32-wavpack.noarch: W: spelling-error Summary(en_US) audiocodec -> audiological mingw32-wavpack.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw32-wavpack.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw32-wavpack.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libwavpack.dll.a mingw32-wavpack.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/wavpack/wavpack.h mingw32-wavpack.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libwavpack.dll.a mingw32-wavpack.noarch: W: spurious-executable-perm /usr/i686-w64-mingw32/sys-root/mingw/lib/libwavpack.dll.a mingw32-wavpack.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/wavpack.pc mingw32-wavpack.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw32-wavpack-tools.noarch: W: spelling-error Summary(en_US) audiocodec -> audiological mingw32-wavpack-tools.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw32-wavpack-tools.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw32-wavpack-tools.noarch: W: no-documentation mingw32-wavpack-tools.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-wavpack.noarch: W: spelling-error Summary(en_US) audiocodec -> audiological mingw64-wavpack.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw64-wavpack.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw64-wavpack.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libwavpack.dll.a mingw64-wavpack.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/wavpack/wavpack.h mingw64-wavpack.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libwavpack.dll.a mingw64-wavpack.noarch: W: spurious-executable-perm /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libwavpack.dll.a mingw64-wavpack.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/wavpack.pc mingw64-wavpack.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw64-wavpack-tools.noarch: W: spelling-error Summary(en_US) audiocodec -> audiological mingw64-wavpack-tools.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw64-wavpack-tools.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw64-wavpack-tools.noarch: W: no-documentation mingw64-wavpack-tools.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw-wavpack.src: W: spelling-error Summary(en_US) audiocodec -> audiological mingw-wavpack.src: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw-wavpack.src: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy 5 packages and 0 specfiles checked; 2 errors, 29 warnings. All the warnings seem fine to ignore. Rpmlint (installed packages) ---------------------------- # rpmlint mingw32-wavpack mingw64-wavpack mingw32-wavpack-too ls mingw64-wavpack-tools mingw32-wavpack.noarch: W: spelling-error Summary(en_US) audiocodec -> audiological mingw32-wavpack.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw32-wavpack.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw64-wavpack.noarch: W: spelling-error Summary(en_US) audiocodec -> audiological mingw64-wavpack.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw64-wavpack.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw32-wavpack-tools.noarch: W: spelling-error Summary(en_US) audiocodec -> audiological mingw32-wavpack-tools.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw32-wavpack-tools.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw32-wavpack-tools.noarch: W: no-documentation mingw64-wavpack-tools.noarch: W: spelling-error Summary(en_US) audiocodec -> audiological mingw64-wavpack-tools.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless mingw64-wavpack-tools.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw64-wavpack-tools.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 14 warnings. # echo 'rpmlint-done:' All the warnings seem fine to ignore. Requires -------- mingw32-wavpack (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem mingw32-pkg-config mingw64-wavpack (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem mingw64-pkg-config mingw32-wavpack-tools (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libwavpack-1.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem mingw32-wavpack mingw64-wavpack-tools (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libwavpack-1.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem mingw64-wavpack Provides -------- mingw32-wavpack: mingw32(libwavpack-1.dll) mingw32-wavpack mingw64-wavpack: mingw64(libwavpack-1.dll) mingw64-wavpack mingw32-wavpack-tools: mingw32-wavpack-tools mingw64-wavpack-tools: mingw64-wavpack-tools Source checksums ---------------- http://www.wavpack.com/wavpack-4.60.1.tar.bz2 : CHECKSUM(SHA256) this package : 175ee4f2effd6f51e6ec487956f41177256bf892c2e8e07de5d27ed4ee6888c5 CHECKSUM(SHA256) upstream package : 175ee4f2effd6f51e6ec487956f41177256bf892c2e8e07de5d27ed4ee6888c5 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1064579 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review