https://bugzilla.redhat.com/show_bug.cgi?id=1057919 --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Michael Schwendt from comment #2) > > Summary: A library for highly efficient multi-dimensional array > > I would find it worthwhile to mention that it's a header-only library or > "header-only API" and written in C++: > > Summary: C++ template library for highly efficient multi-dimensional arrays > > Writing "arrays" instead of "array" sounds like more correct English. Unless > it can only be used for a single array, and then I would insert "a" before > "highly". Ok. > > BuildArch: noarch > > It is beneficial to build header-only src.pms arch-specific, which would be > the only way to test-build anything for all target archs and to run a > test-suite arch-specific (e.g. in a %check section). > > The libflatarray build process clearly compiles several files, but I haven't > checked whether it runs those from the "test" subdir. > > Whether the -devel subpackage may be "noarch" depends solely on its contents. Currently it's noarch, but I will remove the buildarch mark since it may become a shared library in the future. > > %package devel > > Treating them like static libs (since the header-only stuff will be built > in) is not a strict requirement yet, but helpful. > Provides: libflatarray-static = %{version}-%{release} > > The FPC ticket "Guidelines needed for header only libraries" is still open: > https://fedorahosted.org/fpc/ticket/337 I may add this later when the fpc ticket comes true. > > %description devel > > This package contains libraries and header files for > > developing applications that use %{name}. > > No libraries included. Preserved for the future. This library may provide shared libraries later(confirmed by upstream), so I don't want to change the description. > > %install > > make install DESTDIR=%{buildroot} > > Nowadays there is %make_install (rpm -E %make_install), which saves some > typing. Any issues around still? If not I think Denis can approve this, thank you all! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review