[Bug 1057919] Review Request: libflatarray - A library for highly efficient multi-dimensional array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1057919



--- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> Summary:        A library for highly efficient multi-dimensional array

I would find it worthwhile to mention that it's a header-only library or
"header-only API" and written in C++:

  Summary: C++ template library for highly efficient multi-dimensional arrays

Writing "arrays" instead of "array" sounds like more correct English. Unless it
can only be used for a single array, and then I would insert "a" before
"highly".


> BuildArch:      noarch

It is beneficial to build header-only src.pms arch-specific, which would be the
only way to test-build anything for all target archs and to run a test-suite
arch-specific (e.g. in a %check section).

The libflatarray build process clearly compiles several files, but I haven't
checked whether it runs those from the "test" subdir.

Whether the -devel subpackage may be "noarch" depends solely on its contents.


> %package        devel

Treating them like static libs (since the header-only stuff will be built in)
is not a strict requirement yet, but helpful.
  Provides: libflatarray-static = %{version}-%{release}

The FPC ticket "Guidelines needed for header only libraries" is still open:
https://fedorahosted.org/fpc/ticket/337


> %description    devel
> This package contains libraries and header files for
> developing applications that use %{name}.

No libraries included.


> %install
> make install DESTDIR=%{buildroot}

Nowadays there is %make_install (rpm -E %make_install), which saves some
typing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]