https://bugzilla.redhat.com/show_bug.cgi?id=1043573 --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Sandro Mani from comment #4) > Full review below. Issues: > - Missing in post and postun: > /usr/bin/update-desktop-database &> /dev/null || : > - These BR are not needed: gcc-c++ > - Must require hicolor-icon-theme > - Sould use -p with install to preserve timestamps > - Install desktop file via > desktop-file-install --dir=%{buildroot}%{_datadir}/applications/ > %{SOURCE2} > and remove desktop-file-validate call All fixed. Spec URL: http://in.waw.pl/~zbyszek/fedora/openav-luppp.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/openav-luppp-1.0-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review