https://bugzilla.redhat.com/show_bug.cgi?id=1048493 --- Comment #17 from Antonio Trande <anto.trande@xxxxxxxxx> --- 1) Please remove bundled "jemalloc" since Fedora already has the packaged one; Done. 2) As for bundled "libtheora" and others, there is some doubt whether we really need them bundled nowadays, that Mozilla thread is aged (anyway, I'm going to check this out shortly); 3) Please decide with the issue whether "xulrunner" is bundled here or not? This triggers "xulrunner-devel" presence in build dependencies; Bearing in mind the Martin's comment (comment#12), xulrunner is compiled even if I can also not do that for now. We see what FPC says. 4) Right now, "-devel" contains both static and dynamic libs, seems violates this: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 A static sub-package is built now. 5) Maybe "make %{?_smp_mflags}" would also work? Fixed. 6) Strange: "icecat.x86_64: W: desktopfile-without-binary /usr/share/applications/icecat-24.0.desktop icecat", also warnings like "unversioned-explicit-provides", and so on; Fixed now. 7) Probably, better to provide links to i18n ".xpi" files separately instead of preparing a solid archive. It will form a bunch of files but allows to check URL consistency and checksums, as well. Not a requirement, but a suggestion; Maybe this complicates too much the file spec. 8) Please mark all eventually bundled components as "bundled()"; Done. 9) I agree that it's applicable here - "When an application needs unreleased features of a library and that library has committed to those features (usually, the changes are checked into the trunk branch of the upstream's revision control system) but the library has not yet made a release that has that code an exception may be granted to bundle that library until the Fedora packages contain the necessary extra features" - but it requires to request an exception from FPC, anyway. From guidelines: "You must note that the library has been granted an exception in a spec file comment with a link to the FPC ticket where the exception was granted." https://fedorahosted.org/fpc/ticket/391 Spec URL: http://sagitter.fedorapeople.org/Icecat/icecat.spec SRPM URL: http://sagitter.fedorapeople.org/Icecat/icecat-24.0-5.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review