https://bugzilla.redhat.com/show_bug.cgi?id=1062324 Adam Williamson <awilliam@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |awilliam@xxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Adam Williamson <awilliam@xxxxxxxxxx> --- What the hell, I'll take it. Builds fine in koji on rawhide. rpmlint output looks good: [adamw@adam SRPMS]$ rpmlint gstreamer1-vaapi-0.5.8-1.fc20.src.rpm gstreamer1-vaapi.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [adamw@adam x86_64]$ rpmlint gstreamer1-vaapi-* gstreamer1-vaapi.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer 2 packages and 0 specfiles checked; 0 errors, 1 warnings. I don't see any nasties in the licensing, and spot signs off on the patent thing, so we're fine there. "MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory" - there's an auto-generated (library) dependency on gstreamer1, which owns %_libdir/gstreamer-1.0 . as these packages are very tightly coupled I think we're fine without an explicit dependency. As -devel requires the main package I'm not sure it's really necessary to dupe all the documentation, but hey, it's small. All MUST items in the guidelines look fine. Nice job, first time review pass. Package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review