https://bugzilla.redhat.com/show_bug.cgi?id=1048493 Denis Fateyev <denis@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(denis@xxxxxxxxxxx | |) | --- Comment #16 from Denis Fateyev <denis@xxxxxxxxxxx> --- Updated review including latest changes: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ===== MUST items ===== C/C++: [!]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package does not contain duplicates in %files. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in icecat [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in icecat [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [!]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: icecat-devel. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [-]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [!]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4280320 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: icecat-24.0-4.fc20.x86_64.rpm icecat-devel-24.0-4.fc20.x86_64.rpm icecat-24.0-4.fc20.src.rpm icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/icecat ['%{mozappdir}'] icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/icecat-bin ['%{mozappdir}'] icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/mozilla-xremote-client ['%{mozappdir}'] icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/components/libmozgnome.so ['%{mozappdir}'] icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/browser/components/libbrowsercomps.so ['%{mozappdir}'] icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/libmozalloc.so ['%{mozappdir}'] icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/components/libdbusservice.so ['%{mozappdir}'] icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/libxul.so ['%{mozappdir}'] icecat.x86_64: E: missing-call-to-setgroups /usr/lib64/icecat-24.0/libxul.so icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/webapprt-stub ['%{mozappdir}'] icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/plugin-container ['%{mozappdir}'] icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/inspector/selector-search.js icecat.x86_64: E: wrong-script-end-of-line-encoding /usr/lib64/icecat-24.0/browser/modules/devtools/inspector/selector-search.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/extensions/privacy_features@xxxxxxxxxxxxxxxx/chrome/locale/es-AR/privacy_features.properties icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/VariablesViewController.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/Parser.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/StyleSheetEditor.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/css/ui.css icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/components/NetworkGeolocationProvider.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/devtools/gcli.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_async_worker.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/devtools/SourceMap.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/framework/toolbox.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/DeveloperToolbar.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/inspector/highlighter.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/StyleEditorDebuggee.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/en-US/locale/browser/devtools/tilt.properties icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/styleinspector/css-logic.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-utils.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/images/circlearrow.svg icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/markupview/markup-view.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/shared/telemetry.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_win_allthreads.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_unix_allthreads.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/ProfilerPanel.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/SplitView.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/gDevTools.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/_PromiseWorker.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/AppCacheUtils.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/BuiltinCommands.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_async_front.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/ViewHelpers.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/main.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/inspector/selection.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/LayoutHelpers.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/tilt/TiltWorkerCrafter.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/framework/webconsole.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/DebuggerProcess.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_shared_front.jsm icecat.x86_64: E: incorrect-fsf-address /usr/lib64/icecat-24.0/browser/extensions/https-everywhere@xxxxxxx/chrome/content/code/NSS.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_win_back.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/ospath_unix_back.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/CmdTilt.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/ProfilerHelpers.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-visualizer.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/shared/undo.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/ProfilerController.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/tilt/TiltWorkerPicker.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/CmdScratchpad.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/StyleEditorPanel.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/responsivedesign.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/framework/toolbox-options.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/framework/toolbox-hosts.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/styleinspector/rule-view.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/css/tree.css icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/devtools/Templater.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/ProgressReporter.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/shared/inplace-editor.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_shared_allthreads.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/DOMHelpers.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_unix_back.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/DebuggerPanel.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/CmdInspect.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/cleopatra.html icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/parser.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-gl.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/CmdResize.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_unix_front.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/FloatingScrollbars.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/shared/event-emitter.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/CmdEdit.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/framework/sidebar.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-visualizer-style.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/osfile_win_front.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/images/throbber.svg icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/StyleEditorUI.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/AutocompletePopup.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/tabview/utils.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/scratchpad-manager.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/VariablesView.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/inspector/breadcrumbs.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/images/treetwisty.svg icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/osfile/ospath_win_back.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/parserWorker.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/styleinspector/computed-view.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/inspector/inspector-panel.js icecat.x86_64: E: zero-length /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/images/noise.png icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/shared/theme-switching.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/tree.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/gcli.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/ui.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/modules/Promise.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/Commands.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/cmd-profiler.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/framework/target.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/StyleEditorUtil.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/BreadcrumbsWidget.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-math.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/styleinspector/style-inspector.js icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/CmdDebugger.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/NetMonitorPanel.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/SideMenuWidget.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/browser/modules/devtools/Jsbeautify.jsm icecat.x86_64: E: script-without-shebang /usr/lib64/icecat-24.0/chrome/en-US/locale/en-US/pipnss/pipnss.properties icecat.x86_64: W: no-manual-page-for-binary icecat icecat.x86_64: W: desktopfile-without-binary /usr/share/applications/icecat-24.0.desktop icecat icecat-devel.x86_64: W: unstripped-binary-or-object /usr/lib64/icecat-devel-24.0/sdk/bin/xpcshell icecat-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-devel-24.0/sdk/bin/xpcshell ['%{mozappdir}'] icecat-devel.x86_64: W: no-documentation icecat-devel.x86_64: E: incorrect-fsf-address /usr/include/icecat-24.0/cairo/cairo-features.h icecat-devel.x86_64: E: non-executable-script /usr/lib64/icecat-devel-24.0/sdk/bin/xpidl.py 0644L /usr/bin/env icecat-devel.x86_64: E: non-executable-script /usr/lib64/icecat-devel-24.0/sdk/bin/header.py 0644L /usr/bin/env icecat-devel.x86_64: W: cross-directory-hard-link /usr/include/icecat-24.0/CompositorParent.h /usr/include/icecat-24.0/mozilla/layers/CompositorParent.h icecat-devel.x86_64: W: cross-directory-hard-link /usr/include/icecat-24.0/mozilla/Selection.h /usr/include/icecat-24.0/Selection.h icecat-devel.x86_64: E: incorrect-fsf-address /usr/include/icecat-24.0/cairo/cairo-platform.h icecat-devel.x86_64: W: cross-directory-hard-link /usr/include/icecat-24.0/mozilla/layers/CompositorChild.h /usr/include/icecat-24.0/CompositorChild.h icecat-devel.x86_64: W: dangling-symlink /usr/lib64/icecat-devel-24.0/bin /usr/lib64/icecat-24.0 icecat-devel.x86_64: W: cross-directory-hard-link /usr/include/icecat-24.0/mozilla/layers/D3D9SurfaceImage.h /usr/include/icecat-24.0/D3D9SurfaceImage.h icecat-devel.x86_64: W: spurious-executable-perm /usr/include/icecat-24.0/skia/SkAdvancedTypefaceMetrics.h icecat-devel.x86_64: W: cross-directory-hard-link /usr/include/icecat-24.0/mozilla/layers/ShadowLayersManager.h /usr/include/icecat-24.0/ShadowLayersManager.h icecat-devel.x86_64: W: cross-directory-hard-link /usr/include/icecat-24.0/ImageHost.h /usr/include/icecat-24.0/mozilla/layers/ImageHost.h icecat-devel.x86_64: E: non-executable-script /usr/lib64/icecat-devel-24.0/sdk/bin/typelib.py 0644L /usr/bin/env icecat.src:83: W: unversioned-explicit-provides webclient icecat.src:192: W: macro-in-comment %{xulrunnerdir} icecat.src:297: W: macro-in-comment %{_libdir} icecat.src: W: %ifarch-applied-patch Patch1: %{name}-disable-neon.patch icecat.src: W: invalid-url Source4: icecat-langpacks.tar.gz 3 packages and 0 specfiles checked; 121 errors, 17 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- icecat-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env icecat(x86-64) icecat (rpmlib, GLIBC filtered): /bin/bash /bin/sh fedora-bookmarks ld-linux-x86-64.so.2()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXrender.so.1()(64bit) libXt.so.6()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libdl.so.2()(64bit) libffi.so.6()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libhunspell-1.3.so.0()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libmozalloc.so()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnss3.so(NSS_3.10)(64bit) libnss3.so(NSS_3.10.2)(64bit) libnss3.so(NSS_3.11)(64bit) libnss3.so(NSS_3.11.1)(64bit) libnss3.so(NSS_3.11.7)(64bit) libnss3.so(NSS_3.12)(64bit) libnss3.so(NSS_3.12.3)(64bit) libnss3.so(NSS_3.12.9)(64bit) libnss3.so(NSS_3.13)(64bit) libnss3.so(NSS_3.2)(64bit) libnss3.so(NSS_3.3)(64bit) libnss3.so(NSS_3.4)(64bit) libnss3.so(NSS_3.5)(64bit) libnss3.so(NSS_3.6)(64bit) libnss3.so(NSS_3.7)(64bit) libnss3.so(NSS_3.9)(64bit) libnss3.so(NSS_3.9.2)(64bit) libnss3.so(NSS_3.9.3)(64bit) libnssutil3.so()(64bit) libnssutil3.so(NSSUTIL_3.12)(64bit) libnssutil3.so(NSSUTIL_3.12.3)(64bit) libnssutil3.so(NSSUTIL_3.13)(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libpulse.so.0()(64bit) librt.so.1()(64bit) libsmime3.so()(64bit) libsmime3.so(NSS_3.13)(64bit) libsmime3.so(NSS_3.15)(64bit) libsmime3.so(NSS_3.2)(64bit) libsmime3.so(NSS_3.3)(64bit) libsmime3.so(NSS_3.4)(64bit) libsmime3.so(NSS_3.4.1)(64bit) libsmime3.so(NSS_3.6)(64bit) libsmime3.so(NSS_3.9.3)(64bit) libsqlite3.so.0()(64bit) libssl3.so()(64bit) libssl3.so(NSS_3.12.6)(64bit) libssl3.so(NSS_3.13)(64bit) libssl3.so(NSS_3.13.2)(64bit) libssl3.so(NSS_3.14)(64bit) libssl3.so(NSS_3.2)(64bit) libssl3.so(NSS_3.4)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libvpx.so.1()(64bit) libxul.so()(64bit) libxul.so(xul24.0)(64bit) libz.so.1()(64bit) nspr nss rtld(GNU_HASH) Provides -------- icecat-devel: icecat-devel icecat-devel(x86-64) icecat-static icecat: icecat icecat(x86-64) libbrowsercomps.so()(64bit) libbrowsercomps.so(EXPORTED)(64bit) libdbusservice.so()(64bit) libdbusservice.so(EXPORTED)(64bit) libmozalloc.so()(64bit) libmozgnome.so()(64bit) libmozgnome.so(EXPORTED)(64bit) libxul.so()(64bit) libxul.so(xul24.0)(64bit) mimehandler(application/vnd.mozilla.xul+xml) mimehandler(application/xhtml+xml) mimehandler(text/html) mimehandler(text/mml) mimehandler(text/xml) mimehandler(x-scheme-handler/http) mimehandler(x-scheme-handler/https) webclient Unversioned so-files -------------------- icecat: /usr/lib64/icecat-24.0/browser/components/libbrowsercomps.so icecat: /usr/lib64/icecat-24.0/components/libdbusservice.so icecat: /usr/lib64/icecat-24.0/components/libmozgnome.so icecat: /usr/lib64/icecat-24.0/libmozalloc.so icecat: /usr/lib64/icecat-24.0/libxul.so Source checksums ---------------- http://ftp.gnu.org/gnu/gnuzilla/24/icecat-24.0.tar.gz : CHECKSUM(SHA256) this package : 2a79e6db8831a4047030a0451036a34a97fde455fba7a949efde34052b97bfef CHECKSUM(SHA256) upstream package : 2a79e6db8831a4047030a0451036a34a97fde455fba7a949efde34052b97bfef Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --rpm-spec --prebuilt --name icecat Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, Java, C/C++ Disabled plugins: Python, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ---------------------------- Now review notes: 1) Please remove bundled "jemalloc" since Fedora already has the packaged one; 2) As for bundled "libtheora" and others, there is some doubt whether we really need them bundled nowadays, that Mozilla thread is aged (anyway, I'm going to check this out shortly); 3) Please decide with the issue whether "xulrunner" is bundled here or not? This triggers "xulrunner-devel" presence in build dependencies; 4) Right now, "-devel" contains both static and dynamic libs, seems violates this: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 5) Maybe "make %{?_smp_mflags}" would also work? 6) Strange: "icecat.x86_64: W: desktopfile-without-binary /usr/share/applications/icecat-24.0.desktop icecat", also warnings like "unversioned-explicit-provides", and so on; 7) Probably, better to provide links to i18n ".xpi" files separately instead of preparing a solid archive. It will form a bunch of files but allows to check URL consistency and checksums, as well. Not a requirement, but a suggestion; 8) Please mark all eventually bundled components as "bundled()"; 9) I agree that it's applicable here - "When an application needs unreleased features of a library and that library has committed to those features (usually, the changes are checked into the trunk branch of the upstream's revision control system) but the library has not yet made a release that has that code an exception may be granted to bundle that library until the Fedora packages contain the necessary extra features" - but it requires to request an exception from FPC, anyway. From guidelines: "You must note that the library has been granted an exception in a spec file comment with a link to the FPC ticket where the exception was granted." -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review