https://bugzilla.redhat.com/show_bug.cgi?id=1058163 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 2 thanks, though I still personally don't think that rationale is good enough to justify the split binary packages. Now, if each binary subpkg pulled in different and big dependencies, then maybe. -common is good. There is no guideline about this, so it's not a review blocker, but I would urge you to reconsider a simpler solution of shipping only a main and -common subpkg. (If you do, I'd be happy to look over the changes prior to committing anything). 6 is still bogus imho. you're benchmarking *opengl* here, not jpg loading speed. not a blocker. and, please do remember to always bump Release and and changelogs when updating the package (even for reviews!), see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs The koji scratch build you referenced doesn't include the fixes (still has -assets subpkg, and and only a -es2 subpkg) Looking good, I'll try to go over nitty-gritty stuff like licensing, source verification later today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review