https://bugzilla.redhat.com/show_bug.cgi?id=1023848 --- Comment #9 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The javadoc subpackage description seems incomplete (eg. contains "the documentation for" %{summary}) - The licenses looks more like ASL 2.0 and MPL 1.1 see the package com.google.javascript.rhino - There is a new v20140110 release (but I know this review came late) - Patches do not link to upstream bugs/comments/lists but it doesn't really need to do so - Consider running the test suite in %check - Missing explicit Requires for jpackage-utils see https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires Maybe guidelines should be updated - Maybe add a synopsis to the man page, you could also use a markup language such as reStructuredText (rst) or markdown (md) for easier writing I can help with that =) - The package should not require junit (only at build time) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "MPL (v1.1) GPL (unversioned/unknown version)", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/dridi/fedora/_reviews/1023848-closure- compiler/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in closure- compiler-javadoc [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: closure-compiler-20131118-1.fc21.noarch.rpm closure-compiler-javadoc-20131118-1.fc21.noarch.rpm closure-compiler-20131118-1.fc21.src.rpm closure-compiler.noarch: W: spelling-error Summary(en_US) minifier -> magnifier closure-compiler.src: W: spelling-error Summary(en_US) minifier -> magnifier 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint closure-compiler-javadoc closure-compiler closure-compiler.noarch: W: spelling-error Summary(en_US) minifier -> magnifier 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- closure-compiler-javadoc (rpmlib, GLIBC filtered): jpackage-utils closure-compiler (rpmlib, GLIBC filtered): /bin/sh android-json-org-java args4j guava java jpackage-utils jsr-305 junit protobuf-java rhino Provides -------- closure-compiler-javadoc: closure-compiler-javadoc closure-compiler: closure-compiler mvn(com.google.javascript:closure-compiler) Source checksums ---------------- http://closure-compiler.googlecode.com/archive/v20131118.zip : CHECKSUM(SHA256) this package : 58452e1aef9825565ca7361aab5db54e3f28690ee97011651161cc69b8b7419c CHECKSUM(SHA256) upstream package : f72cb3b1aa628540576328ca21bfe16a798ec39af90c8c3bcde8ffaeb627bacc However, diff -r shows no differences Jar and class files in source ----------------------------- ./closure-compiler-7f8a374ebc14/lib/junit.jar ./closure-compiler-7f8a374ebc14/lib/findbugs.jar ./closure-compiler-7f8a374ebc14/lib/android-json-org-java.jar ./closure-compiler-7f8a374ebc14/lib/js.jar ./closure-compiler-7f8a374ebc14/lib/guava.jar ./closure-compiler-7f8a374ebc14/lib/args4j.jar ./closure-compiler-7f8a374ebc14/lib/jarjar.jar ./closure-compiler-7f8a374ebc14/lib/protobuf.jar ./closure-compiler-7f8a374ebc14/lib/jsr-305.jar Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1023848 -P java Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review