https://bugzilla.redhat.com/show_bug.cgi?id=1023848 --- Comment #10 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Thank you for the review. > Issues: > ======= > - The javadoc subpackage description seems incomplete > (eg. contains "the documentation for" %{summary}) I get: Summary : API documentation for closure-compiler Description : This package contains the API documentation for closure-compiler. This is rather brief, but sufficient imho. > - The licenses looks more like ASL 2.0 and MPL 1.1 > see the package com.google.javascript.rhino Changed. > - There is a new v20140110 release (but I know this review came late) Updated. > - Patches do not link to upstream bugs/comments/lists > but it doesn't really need to do so I don't think that upstream will be interested in those patches. Maybe the manpage once it's in final form can be upstreamed. > - Consider running the test suite in %check One test seems to require google-caja for work. When it is removed, there still are failures. I left the necessary commands ifdeffed-out in the spec file (enable with --define '_check 1'). Afaict, those are failures related to some test fixtures, possibly not important. > - Missing explicit Requires for jpackage-utils > see https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires Added. > Maybe guidelines should be updated I think the guidelines are OK. > - Maybe add a synopsis to the man page, you could also use a markup language such as reStructuredText (rst) or markdown (md) for easier writing I can help with that =) I converted the manpage to docbook. It could use a bit of tweaking still. Patches welcome :) > - The package should not require junit (only at build time) Removed. I think all issues are fixed (or justified). Spec URL: http://in.waw.pl/~zbyszek/fedora/closure-compiler.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/closure-compiler-20140110-1.fc20.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6493214 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review