https://bugzilla.redhat.com/show_bug.cgi?id=1010512 --- Comment #17 from Timothy St. Clair <tstclair@xxxxxxxxxx> --- Updated, same URLs. Notes are inlined below. > - mesos must BuildRequire: python2-devel. See > http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - done > - The spec must work from a pristine upstream tarball unless there are legal > reasons why we cannot. Please move all bundled library removal in the %prep > scriptlet and use an upstream tarball. - done >- Integration.patch is 1.8 mb and primarily consists of file moves, which makes > it tedious to inspect. Please move files in %prep rather than in a patch! In >addition, consider splitting up Fedora integration changes into several smaller >patches that each reflect a high-level change. ##################################### # NOTE: The modifications have been broken into three patches which are # consistent with *many* other projects, and are tracking @ # # https://github.com/timothysc/mesos # Full integration stream is: https://github.com/timothysc/mesos/tree/0.16.0-integ # # The shuffle patch is maintained because it is a # patch that is trying to be pushed upstream, thus breaking it out as a series # of steps doesn't make sense, but has been isolated into it's own patch per review. #################################### > - mesos should not own %{_unitdir}. - done > - The python interface should go in %{python_sitearch}. As it stands, it > looks like it's getting built but not installed. (It looks like the makefile > needs to call out to setup.py.) Currently upstream builds a client library, and that the cli tools do not depend on. There are open upstream JIRA's around language bindings, and I'm tracking. However, I don't want to prematurely put them into the wild until they have vetted. https://issues.apache.org/jira/browse/MESOS-899 This also holds for the java interface which also has the same issue atm. > - I think %{python_sitelib} is a more appropriate place for the (internal?) > modules that get installed in libexecdir: > https://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir If these are > part of the mesos module (from the client library), I think they'll need to go > in sitearch since the rest of the mesos module is arch-specific. - done -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review