https://bugzilla.redhat.com/show_bug.cgi?id=1010512 --- Comment #16 from Will Benton <willb@xxxxxxxxxx> --- (In reply to Timothy St. Clair from comment #15) > updated, with same urls. > > You will notice I conditionalized the .spec file around that. I did! Thanks for changing the default behavior; you can remove those conditionals and related comments when you make these last few changes. Here's the rest of my updated review (reflecting the spec as of earlier today with the generated tarball): Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - mesos must BuildRequire: python2-devel. See http://fedoraproject.org/wiki/Packaging:Python#BuildRequires - The spec must work from a pristine upstream tarball unless there are legal reasons why we cannot. Please move all bundled library removal in the %prep scriptlet and use an upstream tarball. - Integration.patch is 1.8 mb and primarily consists of file moves, which makes it tedious to inspect. Please move files in %prep rather than in a patch! In addition, consider splitting up Fedora integration changes into several smaller patches that each reflect a high-level change. - mesos should not own %{_unitdir}. - The python interface should go in %{python_sitearch}. As it stands, it looks like it's getting built but not installed. (It looks like the makefile needs to call out to setup.py.) - I think %{python_sitelib} is a more appropriate place for the (internal?) modules that get installed in libexecdir: https://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir If these are part of the mesos module (from the client library), I think they'll need to go in sitearch since the rest of the mesos module is arch-specific. - I'll buy that the rpmlint error is possibly spurious, and I see that you've opened a JIRA upstream about it. - Consider splitting the web UI out into a noarch subpackage. Also, you should track the "handwavy future" of the Web Assets work, since that will impact this package sooner or later: http://fedoraproject.org/wiki/Changes/Web_Assets#Handwavy_Future ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "BSD (3 clause)", "Unknown or generated". 223 files have unknown license. Detailed output of licensecheck in /home/wibenton/devel/review/1010512-mesos/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd, /etc/tmpfiles.d [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/systemd/system(systemd) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [!]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python - supply proper BuildRequires for the major versions of python you wish to support - If we for intend users to use the Mesos python interface, it needs to be packaged appropriately; see above under "issues" for detail. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. - fine, this doesn't work upstream [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. - but please use upstream tarball instead, as above [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: The placement of pkgconfig(.pc) files are correct. [!]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. - see above under "issues" [x]: Rpmlint is run on all installed packages. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mesos-0.16.0-2.d0cb03f.fc21.x86_64.rpm mesos-devel-0.16.0-2.d0cb03f.fc21.x86_64.rpm mesos-0.16.0-2.d0cb03f.fc21.src.rpm mesos.x86_64: E: missing-call-to-setgroups /usr/lib64/libmesos-0.16.0.so.0.0.0 mesos.x86_64: W: non-conffile-in-etc /etc/mesos/mesos-deploy-env.sh.template mesos.x86_64: W: non-conffile-in-etc /etc/mesos/mesos-slave-env.sh.template mesos.x86_64: W: non-conffile-in-etc /etc/mesos/mesos-master-env.sh.template mesos.x86_64: W: log-files-without-logrotate /var/log/mesos mesos.x86_64: W: no-manual-page-for-binary mesos-stop-slaves.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-log mesos.x86_64: W: no-manual-page-for-binary mesos mesos.x86_64: W: no-manual-page-for-binary mesos-local mesos.x86_64: W: no-manual-page-for-binary mesos-start-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-daemon.sh mesos.x86_64: W: no-manual-page-for-binary mesos-slave mesos.x86_64: W: no-manual-page-for-binary mesos-ps mesos.x86_64: W: no-manual-page-for-binary mesos-tail mesos.x86_64: W: no-manual-page-for-binary mesos-master mesos.x86_64: W: no-manual-page-for-binary mesos-start-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-resolve mesos.x86_64: W: no-manual-page-for-binary mesos-execute mesos.x86_64: W: no-manual-page-for-binary mesos-cat mesos.x86_64: W: no-manual-page-for-binary mesos-start-slaves.sh mesos.src: W: strange-permission generate-tarball.sh 0775L mesos.src: W: invalid-url Source0: mesos-0.16.0-rc1-clean.tar.gz 3 packages and 0 specfiles checked; 1 errors, 23 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mesos-devel mesos mesos.x86_64: E: missing-call-to-setgroups /usr/lib64/libmesos-0.16.0.so.0.0.0 mesos.x86_64: W: non-conffile-in-etc /etc/mesos/mesos-deploy-env.sh.template mesos.x86_64: W: non-conffile-in-etc /etc/mesos/mesos-slave-env.sh.template mesos.x86_64: W: non-conffile-in-etc /etc/mesos/mesos-master-env.sh.template mesos.x86_64: W: log-files-without-logrotate /var/log/mesos mesos.x86_64: W: no-manual-page-for-binary mesos-stop-slaves.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-log mesos.x86_64: W: no-manual-page-for-binary mesos mesos.x86_64: W: no-manual-page-for-binary mesos-local mesos.x86_64: W: no-manual-page-for-binary mesos-start-cluster.sh mesos.x86_64: W: no-manual-page-for-binary mesos-daemon.sh mesos.x86_64: W: no-manual-page-for-binary mesos-slave mesos.x86_64: W: no-manual-page-for-binary mesos-ps mesos.x86_64: W: no-manual-page-for-binary mesos-tail mesos.x86_64: W: no-manual-page-for-binary mesos-master mesos.x86_64: W: no-manual-page-for-binary mesos-start-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-stop-masters.sh mesos.x86_64: W: no-manual-page-for-binary mesos-resolve mesos.x86_64: W: no-manual-page-for-binary mesos-execute mesos.x86_64: W: no-manual-page-for-binary mesos-cat mesos.x86_64: W: no-manual-page-for-binary mesos-start-slaves.sh 2 packages and 0 specfiles checked; 1 errors, 21 warnings. # echo 'rpmlint-done:' Requires -------- mesos-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libmesos-0.16.0.so.0()(64bit) mesos(x86-64) mesos (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env config(mesos) libc.so.6()(64bit) libcurl.so.4()(64bit) libev.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libglog.so.0()(64bit) libhttp_parser.so.2()(64bit) libjvm.so()(64bit) libjvm.so(SUNWprivate_1.1)(64bit) libleveldb.so.1()(64bit) libm.so.6()(64bit) libmesos-0.16.0.so.0()(64bit) libprotobuf.so.8()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libzookeeper_mt.so.2()(64bit) protobuf-python rtld(GNU_HASH) Provides -------- mesos-devel: mesos-devel mesos-devel(x86-64) pkgconfig(mesos) mesos: config(mesos) libmesos-0.16.0.so.0()(64bit) mesos mesos(x86-64) Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1010512 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review