https://bugzilla.redhat.com/show_bug.cgi?id=951582 --- Comment #11 from Eric Smith <spacewar@xxxxxxxxx> --- Issues: * Subpackages don't have versioned dependencies * COPYING isn't in the main package %files * License tag may need to include zlib/libpng * Static libraries should be in -static subpackage * I think there may be a problem with versioned vs unversioned doc dirs. You may need to include the macro %{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}} and use that variable rather than %{_docdir} Full review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Static libraries in -static subpackage, if present. Note: Archive *.a files found in psi4-devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in psi4-data , psi4-devel , psi4-doc [x]: Package complies to the Packaging Guidelines [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "GPL (v2 or later) LGPL (v2 or later)", "Unknown or generated", "*No copyright* zlib/libpng", "zlib/libpng", "MIT/X11 (BSD like)", "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later) (with incorrect FSF address) LGPL (v2 or later) (with incorrect FSF address)", "*No copyright* GPL (v2 or later)". 346 files have unknown license. Detailed output of licensecheck in /home/eric/951582-psi4/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Uses parallel make. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: psi4-4.0-0.5.b5.fc19.x86_64.rpm psi4-data-4.0-0.5.b5.fc19.noarch.rpm psi4-devel-4.0-0.5.b5.fc19.x86_64.rpm psi4-doc-4.0-0.5.b5.fc19.noarch.rpm psi4.x86_64: W: spelling-error Summary(en_US) initio -> initiation psi4.x86_64: W: spelling-error %description -l en_US initio -> initiation psi4.x86_64: W: no-documentation psi4.x86_64: W: no-manual-page-for-binary psi4 psi4-data.noarch: W: no-documentation psi4-data.noarch: E: non-executable-script /usr/share/psi/python/pcmgetkw.py 0644L /usr/bin/env psi4-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint psi4 psi4-data psi4-devel psi4-doc psi4.x86_64: W: spelling-error Summary(en_US) initio -> initiation psi4.x86_64: W: spelling-error %description -l en_US initio -> initiation psi4.x86_64: W: no-documentation psi4.x86_64: W: no-manual-page-for-binary psi4 psi4-data.noarch: W: no-documentation psi4-data.noarch: E: non-executable-script /usr/share/psi/python/pcmgetkw.py 0644L /usr/bin/env psi4-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 6 warnings. # echo 'rpmlint-done:' Requires -------- psi4 (rpmlib, GLIBC filtered): libatlas.so.3()(64bit) libboost_filesystem-mt.so.1.53.0()(64bit) libboost_python.so.1.53.0()(64bit) libboost_regex-mt.so.1.53.0()(64bit) libboost_serialization-mt.so.1.53.0()(64bit) libboost_system-mt.so.1.53.0()(64bit) libboost_thread-mt.so.1.53.0()(64bit) libc.so.6()(64bit) libcblas.so.3()(64bit) libderiv-stable.so.1()(64bit) libdl.so.2()(64bit) libf77blas.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgfortran.so.3()(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_2.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libgomp.so.1(OMP_2.0)(64bit) libint-stable.so.1()(64bit) liblapack.so.3()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libquadmath.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libutil.so.1()(64bit) numpy psi4-data rtld(GNU_HASH) psi4-data (rpmlib, GLIBC filtered): psi4-devel (rpmlib, GLIBC filtered): psi4-doc (rpmlib, GLIBC filtered): Provides -------- psi4: psi4 psi4(x86-64) psi4-data: psi4-data psi4-devel: psi4-devel psi4-devel(x86-64) psi4-static(x86-64) psi4-doc: psi4-doc Source checksums ---------------- http://downloads.sourceforge.net/psicode/psi4.0b5.tar.gz : CHECKSUM(SHA256) this package : 394059b62b0d87867969097d212e1390873f9724d5aac6a777012fa49003f1d9 CHECKSUM(SHA256) upstream package : 394059b62b0d87867969097d212e1390873f9724d5aac6a777012fa49003f1d9 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-19-x86_64 Command line :/usr/bin/fedora-review -b 951582 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review