https://bugzilla.redhat.com/show_bug.cgi?id=951582 --- Comment #12 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to Eric Smith from comment #11) > Issues: > * Subpackages don't have versioned dependencies > [!]: Fully versioned dependency in subpackages, if present. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in psi4-data This is a false positive. psi4-data doesn't need the main package. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requiring_Base_Package > * COPYING isn't in the main package %files Added LICENSE and COPYING to %doc of all independent packages. > * License tag may need to include zlib/libpng This was in a bundled tinyxml library in the bundled madness package. I now remove the bundled madness altogether in %prep. > * Static libraries should be in -static subpackage This package only has static libraries, so the virtual Provides: in the -devel package is OK. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Packaging_Static_Libraries_2 > * I think there may be a problem with versioned vs unversioned doc dirs. > You may need to include the macro > %{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}} > and use that variable rather than %{_docdir} Well, it builds in rawhide and has a unversioned docdir there, so I don't think this is an issue. http://theory.physics.helsinki.fi/~jzlehtol/rpms/psi4.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/psi4-4.0-0.6.b5.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review