[Bug 1045676] Review Request: sunwait - Calculate sunrise, sunset, twilight

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1045676

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
Some remarks:
- Building this package doesn't honor RPM_OPT_FLAGS.
One way to achieve this is to pass RPM_OPT_FLAGS through the environment.
I.e., e.g. to apply this change to your spec:
@@ -27,7 +25,7 @@
 %setup -q

 %build
-make %{?_smp_mflags}
+make %{?_smp_mflags} CFLAGS="${RPM_OPT_FLAGS}"

 %install
 install -d -m 755 ${RPM_BUILD_ROOT}/%{_bindir}

- With RPM_OPT_FLAGS enable, building issues quite a lot of fairly serious
warnings. Without having checked details, it's obvious this code suffers from
its age, with my gut feeling telling me this package could be not 64bit-clean.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]