https://bugzilla.redhat.com/show_bug.cgi?id=1023714 --- Comment #16 from Alec Leamas <leamas.alec@xxxxxxxxx> --- (In reply to Simone Caronni from comment #15) > Issues: > Couple of issues in the %files section: > > %{_datadir}/lpf/packages/%{target_pkg} > %attr(775,pkg-build,pkg-build) /var/lib/lpf/packages/%{target_pkg} > %attr(664,pkg-build,pkg-build) /var/lib/lpf/packages/%{target_pkg}/state > > - First line is redundant with the second one. No. Just removing the second line -> different (and wrong) permissions. > - Third line is redundant with the second one; No. Just removing the third line -> different (and wrong) permissions. > second one already includes > the path. If you want to own only the directory but not the files contained > in it please use %dir. What I do in the third line is to give the state file 664 permissions. IMHO, using %dir would be less clear, it's not obvious in what way lpf-setup-pkg populates this dir. Added some %exclude to get rid of the warnings. Not really happy with this solution, though. > The license is MIT, but there's no license file installed. Please provide > one in %doc. Done. > > lpf-skype.noarch: W: invalid-url URL: http://leamas.fedorapeople.org/skype/4.2.0.11/skype.spec HTTP Error 404: Not Found > > Please fix. Setting upstream to lpf upstream, fixed. > Almost the same issues as in comment number 18 of the lfp-spotify-client > review: And almost the same reply :) > > Diff spec file in url and in SRPM > > Please re-upload spec file or srpm file to match. Done. New links: srpm: http://leamas.fedorapeople.org/lpf-skype/3/lpf-skype-4.2.0.11-3.fc19.src.rpm spec: http://leamas.fedorapeople.org/lpf-skype/3/lpf-skype.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review