https://bugzilla.redhat.com/show_bug.cgi?id=1023714 --- Comment #15 from Simone Caronni <negativo17@xxxxxxxxx> --- Issues: > - Package does not contain duplicates in %files. > Note: warning: File listed twice: /var/lib/lpf/packages/skype/state > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles Couple of issues in the %files section: %{_datadir}/lpf/packages/%{target_pkg} %attr(775,pkg-build,pkg-build) /var/lib/lpf/packages/%{target_pkg} %attr(664,pkg-build,pkg-build) /var/lib/lpf/packages/%{target_pkg}/state - First line is redundant with the second one. - Third line is redundant with the second one; second one already includes the path. If you want to own only the directory but not the files contained in it please use %dir. > [!]: If the source package does not include license text(s) as a separate file > from upstream, the packager SHOULD query upstream to include it. > [!]: Package does not include license text files separate from upstream. > [!]: Package does not include license text files separate from upstream. The license is MIT, but there's no license file installed. Please provide one in %doc. > lpf-skype.noarch: W: invalid-url URL: http://leamas.fedorapeople.org/skype/4.2.0.11/skype.spec HTTP Error 404: Not Found Please fix. Almost the same issues as in comment number 18 of the lfp-spotify-client review: https://bugzilla.redhat.com/show_bug.cgi?id=973069#c18 > Diff spec file in url and in SRPM Please re-upload spec file or srpm file to match. After these fixes I will review the "internal" spec file. Thanks. --Simone --------------------------------- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review