[Bug 1023714] Review Request: lpf-skype: Skype internet phone client package bootstrap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1023714



--- Comment #17 from Simone Caronni <negativo17@xxxxxxxxx> ---
Package APPROVED wrt lpf-skype.spec file.

Now to the bundled skype.spec file. I used to mantain the same for a few years;
would you like to take a look at:

http://slaanesh.fedorapeople.org/skype.spec

Apart from stylistical differences in the SPEC file and description/summaries
the things I notice most are the following:

- Fedora 20+ needs a wrapper because it needs PULSE_LATENCY_MSEC=30; setting it
in a profile under /etc/profile.d does not work.

- Requires webkitgtk%{_isa}; is not pulled automatically in by dependencies and
it's needed for the first html based welcome screen, otherwise if it's not
already configured, there's no way to configure it for the first time.

- ExclusiveArch should be i686 (RPMFusion style) or %{ix86}; x86_64 is not
supported.

- You are missing a prelink configuration file. If you run it for a day, after
prelink has run on any EPEL or Fedora system, the program gets corrupted and
you need to reinstall the rpm. Prelink it's disabled in Fedora 21+, (iirc).

- I avoid stripping by using "%define __spec_install_post
/usr/lib/rpm/brp-compress" at the top of the spec file, don't know what the
impact is compared to your solution.

I've also added you in CC to my (obsolete, probably) Skype review in RPMFusion;
just for reference.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2978

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]