[Bug 1020088] Review Request: blosc - A high performance compressor optimized for binary data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1020088

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
> ... the Requires should be more exact (for -devel)
> Requires:  %{name}%{?_isa} = %{version}-%{release}
Still missing, I think.

> blosc-bench.x86_64: E: non-standard-executable-perm /usr/bin/blosc-bench 0775L

Should be 0755. I suppose that this is inherited from the environment, I have
umask 0002. Probably 'install' instead of cp would be better, since it sets the
permissions to u=rwx,go=rx.

Rpmlint (rest of output)
-------
Checking: blosc-1.2.3-6.fc19.x86_64.rpm
          blosc-devel-1.2.3-6.fc19.x86_64.rpm
          blosc-bench-1.2.3-6.fc19.x86_64.rpm
          blosc-1.2.3-6.fc19.src.rpm
blosc.x86_64: W: spelling-error %description -l en_US datasets -> data sets,
data-sets, databases
blosc-devel.x86_64: W: no-documentation
blosc-bench.x86_64: E: explicit-lib-dependency python-matplotlib
The dependency is OK. python-matplotlib only provides
  python-matplotlib = 1.3.0-1.fc20
  python-matplotlib(x86-64) = 1.3.0-1.fc20
and the non-isa one is  more adequate.

blosc-bench.x86_64: W: spelling-error %description -l en_US memcpy -> memory
blosc-bench.x86_64: W: no-manual-page-for-binary blosc-plot-times
blosc-bench.x86_64: W: no-manual-page-for-binary blosc-bench
blosc.src: W: spelling-error %description -l en_US datasets -> data sets,
data-sets, databases
4 packages and 0 specfiles checked; 2 errors, 6 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint blosc-devel blosc blosc-bench
blosc-devel.x86_64: W: no-documentation
blosc.x86_64: W: spelling-error %description -l en_US datasets -> data sets,
data-sets, databases
blosc-bench.x86_64: E: explicit-lib-dependency python-matplotlib
blosc-bench.x86_64: W: spelling-error %description -l en_US memcpy -> memory
blosc-bench.x86_64: E: non-standard-executable-perm /usr/bin/blosc-bench 0775L
blosc-bench.x86_64: W: no-manual-page-for-binary blosc-plot-times
blosc-bench.x86_64: W: no-manual-page-for-binary blosc-bench
3 packages and 0 specfiles checked; 2 errors, 5 warnings.

Can be ignored.

I think that except those two issues noted at the top, package is OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]