[Bug 1020088] Review Request: blosc - A high performance compressor optimized for binary data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1020088



--- Comment #12 from Thibault North <thibault.north@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #11)
> > ... the Requires should be more exact (for -devel)
> > Requires:  %{name}%{?_isa} = %{version}-%{release}
> Still missing, I think.

Fixed, thanks.

> > blosc-bench.x86_64: E: non-standard-executable-perm /usr/bin/blosc-bench 0775L
> 
> Should be 0755. I suppose that this is inherited from the environment, I
> have umask 0002. Probably 'install' instead of cp would be better, since it
> sets the permissions to u=rwx,go=rx.

Right!

http://tnorth.fedorapeople.org/rev/blosc.spec
http://tnorth.fedorapeople.org/rev/blosc-1.2.3-7.fc19.src.rpm

New rmplint output:
rpmlint -vv blosc-1.2.3-7.fc19.src.rpm blosc-1.2.3-7.fc19.x86_64.rpm
blosc-devel-1.2.3-7.fc19.x86_64.rpm blosc-bench-1.2.3-7.fc19.x86_64.rpm
blosc-debuginfo-1.2.3-7.fc19.x86_64.rpm blosc.spec 
blosc.src: I: checking
blosc.src: W: spelling-error %description -l en_US datasets -> data sets,
data-sets, databases
blosc.src: I: checking-url http://blosc.org (timeout 10 seconds)
blosc.src: I: checking-url http://blosc.org/sources/1.2.3/blosc-1.2.3.tar.gz
(timeout 10 seconds)
blosc.x86_64: I: checking
blosc.x86_64: W: spelling-error %description -l en_US datasets -> data sets,
data-sets, databases
blosc.x86_64: I: checking-url http://blosc.org (timeout 10 seconds)
blosc-devel.x86_64: I: checking
blosc-devel.x86_64: I: checking-url http://blosc.org (timeout 10 seconds)
blosc-devel.x86_64: W: no-documentation
blosc-bench.x86_64: I: checking
blosc-bench.x86_64: E: explicit-lib-dependency python-matplotlib
blosc-bench.x86_64: W: spelling-error %description -l en_US memcpy -> memory
blosc-bench.x86_64: I: checking-url http://blosc.org (timeout 10 seconds)
blosc-bench.x86_64: W: no-manual-page-for-binary blosc-plot-times
blosc-bench.x86_64: W: no-manual-page-for-binary blosc-bench
blosc-debuginfo.x86_64: I: checking
blosc-debuginfo.x86_64: I: checking-url http://blosc.org (timeout 10 seconds)
/home/tnorth/rpmbuild/SPECS/blosc.spec: I: checking-url
http://blosc.org/sources/1.2.3/blosc-1.2.3.tar.gz (timeout 10 seconds)
5 packages and 1 specfiles checked; 1 errors, 6 warnings.

Thanks everyone. I am a bit rusty, it's been a long time :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]