https://bugzilla.redhat.com/show_bug.cgi?id=1020088 --- Comment #10 from Thibault North <thibault.north@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #9) > (In reply to Thibault North from comment #8) > > (In reply to Christopher Meng from comment #6) > > > Try this: > > > > > > %{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}} > > > > s/%{version}// ? > > Doesn't work here, but %global _pkgdocdir %{_docdir}/%{name} seems to make > > it. Thanks. > This is just a fallback for build systems with old rpm. That's why it > is defined with -%{version}, to retain historical behaviour on old systems, > but allowing to use the same %spec. It should be conditional, so that you > get the new behaviour when enabled by the system. Ok, I was trying to have the same behaviour on F19, which wasn't right. > The sed is still wrong, it's backwards... Fixed. > > Also, blosc-plot-times requires python-matplotlib%{?_isa}. I thought that > > requiring it would be ok, but rpmlint complains (explicit-lib-dependency). i > > guess this can be ignored? > Actually, blosc-plot-times is by itself noarch, so I think it's fine with > whatever python-matplotlib, so %{?_isa} can be removed. Done. > > cp -pr %{_pkgdocdir}/bench/plot-speeds.py ${RPM_BUILD_ROOT}/%{_bindir}/%{name}-plot-times > This looks wrong. Indeed, remains of the link. Fixed. http://tnorth.fedorapeople.org/rev/blosc.spec http://tnorth.fedorapeople.org/rev/blosc-1.2.3-6.fc19.src.rpm Thanks for your patience. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review