[Bug 1016807] Review Request: tubo - Library to thread process std-in/std-err/std-out from fork() child

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1016807



--- Comment #4 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Still one more issue, though.

%dir %{_datadir}/gtk-doc/html/lib%{name}
%{_datadir}/gtk-doc/html/lib%{name}/*

In this case the whole folder path /usr/share/gtk-doc/html would stay unowned.
No problem, you could simply add "Requires: gtk-doc" and all is fine. That
package is quite small and doesn't eat up a lot of disk space. But it has a
disadvantage, it pulls a lot of dependencies, and gtk-doc is actually not
needed for libtubo at runtime. In such cases, it is allowed and usual to co-own
the whole folder %{_datadir}/gtk-doc and don't require gtk-doc at all. I can't
find the appropriate guideline for the time being, just have a look at the
first entry of the associated tracking bug:
https://bugzilla.redhat.com/show_bug.cgi?id=604169#c0

And last but not least, a wrong comment has crept in your spec:

## Remove static libs
find $RPM_BUILD_ROOT -name '*.la' -delete

The same as in your librfm review ticket, you know what to do ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]