[Bug 1016807] Review Request: tubo - Library to thread process std-in/std-err/std-out from fork() child

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1016807

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?



--- Comment #3 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6059678

$ rpmlint -i -v *
tubo.src: I: checking
tubo.src: I: checking-url http://xffm.org/libtubo.html (timeout 10 seconds)
tubo.src: W: strange-permission tubo-5.0.7.tar.gz 0600L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

tubo.src: I: checking-url
http://sourceforge.net/projects/xffm/files/libtubo/tubo-5.0.7.tar.gz (timeout
10 seconds)
tubo.armv7hl: I: checking
tubo.armv7hl: I: checking-url http://xffm.org/libtubo.html (timeout 10 seconds)
tubo.i686: I: checking
tubo.i686: I: checking-url http://xffm.org/libtubo.html (timeout 10 seconds)
tubo.x86_64: I: checking
tubo.x86_64: I: checking-url http://xffm.org/libtubo.html (timeout 10 seconds)
tubo-debuginfo.armv7hl: I: checking
tubo-debuginfo.armv7hl: I: checking-url http://xffm.org/libtubo.html (timeout
10 seconds)
tubo-debuginfo.armv7hl: E: incorrect-fsf-address
/usr/src/debug/tubo-5.0.7/src/tubo_static.i
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo-debuginfo.armv7hl: E: incorrect-fsf-address
/usr/src/debug/tubo-5.0.7/src/tubo.c
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo-debuginfo.i686: I: checking
tubo-debuginfo.i686: I: checking-url http://xffm.org/libtubo.html (timeout 10
seconds)
tubo-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/tubo-5.0.7/src/tubo_static.i
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/tubo-5.0.7/src/tubo.c
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo-debuginfo.x86_64: I: checking
tubo-debuginfo.x86_64: I: checking-url http://xffm.org/libtubo.html (timeout 10
seconds)
tubo-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tubo-5.0.7/src/tubo_static.i
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tubo-5.0.7/src/tubo.c
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo-devel.armv7hl: I: checking
tubo-devel.armv7hl: W: summary-not-capitalized C tubo headers and
development-related files
Summary doesn't begin with a capital letter.

tubo-devel.armv7hl: I: checking-url http://xffm.org/libtubo.html (timeout 10
seconds)
tubo-devel.armv7hl: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

tubo-devel.armv7hl: E: incorrect-fsf-address /usr/include/tubo.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo-devel.i686: I: checking
tubo-devel.i686: W: summary-not-capitalized C tubo headers and
development-related files
Summary doesn't begin with a capital letter.

tubo-devel.i686: I: checking-url http://xffm.org/libtubo.html (timeout 10
seconds)
tubo-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

tubo-devel.i686: E: incorrect-fsf-address /usr/include/tubo.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo-devel.x86_64: I: checking
tubo-devel.x86_64: W: summary-not-capitalized C tubo headers and
development-related files
Summary doesn't begin with a capital letter.

tubo-devel.x86_64: I: checking-url http://xffm.org/libtubo.html (timeout 10
seconds)
tubo-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

tubo-devel.x86_64: E: incorrect-fsf-address /usr/include/tubo.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tubo.spec: I: checking-url
http://sourceforge.net/projects/xffm/files/libtubo/tubo-5.0.7.tar.gz (timeout
10 seconds)
10 packages and 1 specfiles checked; 9 errors, 7 warnings.



The old FSF addresses have to be reported upstream.

To make rpmlint happy regarding the not-capitalized summary, you might use the
following template, which you get anyway when creating a new spec with
rpmdev-newspec:

Summary:        Development files for %{name}
...
%description    devel
The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.

It isnot really dangerous to let the tarball have the mentioned permissions,
but you could change it to 0644 as proposed before creating the srpm.

(In reply to Ralf Corsepius from comment #1)
> Building is silent. It's impossible to check whether the compiler is invoked
> correctly from log-files.

After adding this rule and building the library on Koji, I can't see any
peculiarities. Ralf, please have a look at build.log:
http://kojipkgs.fedoraproject.org//work/tasks/9680/6059680/build.log
If you don't have any further objections, I would complete this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]