[Bug 1014336] Review Request: python-halite - Web GUI for SaltStack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1014336

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?



--- Comment #10 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
(In reply to Erik Johnson from comment #9)
> OK, I understand now, thanks. Because we keep the spec files in source
> control, I think I might just use the conditionals to simplify things in
> case we get anyone else to be co-maintainer, so there is less to explain to
> the co-maintainer.

BTW, we keep all our spec files in source control, in our Fedora Git repo ;)
Probably you mean Github or anything else. It's the same thing actually. And
Git has *branches*! This is what we need. If you really want to get rid of all
the obsolete garbage - which becomes obsolete-obsolete once EPEL5 becomes EOL -
then fork a branch named "epel5" and remove all the useless stuff from the
other branches. It's sometimes hard for me to review such a package which is
overloaded with conditions and even more conditions.

I will do the review, but be patient, will probably need some days.

(In reply to Erik Johnson from comment #6)
> However, I did some digging and the the public direct links are available if
> you right-click the "Download" button on the links I originally posted, and
> copy the URL. Given that knowledge, here are the public download links:
> 
> Spec URL:
> https://dl.dropboxusercontent.com/s/dyrl1jkyiwhhzxj/python-halite.spec
> SRPM URL:
> https://dl.dropboxusercontent.com/s/4shqedab21j894f/python-halite-0.1.01-1.
> el6.src.rpm

This works now as I expect. Moreover, a lot of reviewers prefer the
fedora-review tool, and this works only with links which can be fetched
directly with wget or curl (the same behavior as with a right-click and "Save
target as").

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]