https://bugzilla.redhat.com/show_bug.cgi?id=1014336 --- Comment #11 from Erik Johnson <erik@xxxxxxxxxxxxx> --- (In reply to Mario Blättermann from comment #10) > BTW, we keep all our spec files in source control, in our Fedora Git repo ;) Yes, I'm aware. > Probably you mean Github or anything else. It's the same thing actually. And > Git has *branches*! This is what we need. If you really want to get rid of > all the obsolete garbage - which becomes obsolete-obsolete once EPEL5 > becomes EOL - then fork a branch named "epel5" and remove all the useless > stuff from the other branches. It's sometimes hard for me to review such a > package which is overloaded with conditions and even more conditions. > Well, in our repo on github, we keep the spec files in the development branch of the same repo containing our python module, and we don't maintain separate branches for the different Fedora/EPEL versions, because it would frankly be silly to do so. In order to maintain things in a more readable way, it may be a reasonable compromise to maintain an EL6 and a non-EL6 spec on Github. > I will do the review, but be patient, will probably need some days. > No problem, thanks for your time and for the recommendations, this is my first package submission and it has been a great learning experience. > (In reply to Erik Johnson from comment #6) > > However, I did some digging and the the public direct links are available if > > you right-click the "Download" button on the links I originally posted, and > > copy the URL. Given that knowledge, here are the public download links: > > > > Spec URL: > > https://dl.dropboxusercontent.com/s/dyrl1jkyiwhhzxj/python-halite.spec > > SRPM URL: > > https://dl.dropboxusercontent.com/s/4shqedab21j894f/python-halite-0.1.01-1. > > el6.src.rpm > > This works now as I expect. Moreover, a lot of reviewers prefer the > fedora-review tool, and this works only with links which can be fetched > directly with wget or curl (the same behavior as with a right-click and > "Save target as"). Ahh, I see. Thanks for the info! And thanks for pressing me on this point, as I would otherwise not have known that Dropbox still provides actual direct links to shared files. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review