https://bugzilla.redhat.com/show_bug.cgi?id=1014336 --- Comment #9 from Erik Johnson <erik@xxxxxxxxxxxxx> --- (In reply to Mario Blättermann from comment #8) > Indeed, all these things are only needed for EPEL 5. For EPEL >= 6 and all > currently supported Fedora versions, they are useless, because rpm defaults > to them anyway. But this is a post-review task. Well, I know about a lot of > packages which are in Fedora for a long time and entrain all this useless > things also in newer branches and even in Rawhide. Without them, the spec > file would become much better readable and understandable for unexperienced > packagers. If you mean it is too much work to maintain different spec files > for different Git branches, you could set conditions, but this also doesn't > make sense. Keep in mind, due to the age of EPEL5, we still need such > special things therefore, but after EPEL5 becomes EOL in 2017, they become > obsolete generally. Be future-proof and follow my proposal. > > BTW, if you don't plan to maintain your package for EPEL 5 at all, you can > drop the mentioned parts anyway. OK, I understand now, thanks. Because we keep the spec files in source control, I think I might just use the conditionals to simplify things in case we get anyone else to be co-maintainer, so there is less to explain to the co-maintainer. Are there any additional concerns that you have after my recent edits? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review