https://bugzilla.redhat.com/show_bug.cgi?id=1006112 --- Comment #3 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Thank you very much for reviewing. (In reply to Miroslav Suchý from comment #2) > * description should end with dot. (-doc subpackage) Fixed. (Thanks also for proposing https://github.com/lutter/gem2rpm/pull/25!) > * *I* would put README.md into main package (if you disagree, let it be) > > * *I* would keep the original %{gem_name}.gemspec and put it into -doc > subpackage. It may be usefull for developers. (if you disagree, let it be) For these two, I'll respectfully decline. My hope is to keep the packages light-weight if possible (particularly the main package, since that's likely to be installed in a lot of places). If it is important to be consistent, I think these could be proposed as changes to the Ruby Packaging Guidelines wiki page and gem2rpm template. > * remove executable attr from LICENSE > rubygem-exception_notification.noarch: E: script-without-shebang > /usr/share/gems/gems/exception_notification-4.0.0/LICENSE Great catch, thank you. > * .gitkeep can be removed Good catch, and I removed a .gitignore file as well. Package diff: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-exception_notification.git/commit/?id=0885d91392db166049312379d3cdcfc821c07ec6 Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-exception_notification.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-exception_notification-4.0.0-2.fc21.src.rpm Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5930644 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1QlPyNFbxi&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review