https://bugzilla.redhat.com/show_bug.cgi?id=1006112 --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- * description should end with dot. (-doc subpackage) * *I* would put README.md into main package (if you disagree, let it be) * *I* would keep the original %{gem_name}.gemspec and put it into -doc subpackage. It may be usefull for developers. (if you disagree, let it be) * remove executable attr from LICENSE rubygem-exception_notification.noarch: E: script-without-shebang /usr/share/gems/gems/exception_notification-4.0.0/LICENSE * .gitkeep can be removed rubygem-exception_notification-doc.noarch: W: hidden-file-or-dir /usr/share/gems/gems/exception_notification-4.0.0/test/dummy/public/stylesheets/.gitkeep rubygem-exception_notification-doc.noarch: E: zero-length /usr/share/gems/gems/exception_notification-4.0.0/test/dummy/public/stylesheets/.gitkeep rubygem-exception_notification-doc.noarch: W: hidden-file-or-dir /usr/share/gems/gems/exception_notification-4.0.0/test/dummy/lib/tasks/.gitkeep rubygem-exception_notification-doc.noarch: E: zero-length /usr/share/gems/gems/exception_notification-4.0.0/test/dummy/lib/tasks/.gitkeep Otherwise it looks good to me. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=brxCmOJKUy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review