https://bugzilla.redhat.com/show_bug.cgi?id=996618 --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > 1. The %check section is not present. Can you add it? Ah, the test/ directory is not present in gem. So I overlook that. I will add git archive as source1 and will try to run the test. > 2. I think %{gem_instdir}/README.rdoc belongs in the -doc subpackage. I prefer to put README into main package. Other packages use that as well. IMHO this is good habit, as it usually contain very compressed and base information, which give you good information about that package, without the need to install -doc subpackage. > 3. Both %{gem_instdir}/MIT-LICENSE and %{gem_instdir}/README.rdoc should be marked as %doc. Fixed. > 4. I don't see why you would need to ship %{gem_instdir}/%{gem_name}.gemspec, since you're already shipping %{gem_spec}. In my own gems I always delete this second copy of the gemspec (although I can't find anything in the Ruby guidelines about this.) I used to exclude it in past as well. But then I have been pointed by jstribny that %{gem_spec} is that one we generated in %build and it may differ from %{gem_instdir}/%{gem_name}.gemspec, which is the original one. And it may be useful for somebody, so we may put it in -doc. Seems legit to me, so since then, I preserve it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g1Mn2TB4Vw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review