https://bugzilla.redhat.com/show_bug.cgi?id=996618 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ktdreyer@xxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ktdreyer@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- I can take this review. While I work on the details, I noticed the following: 1. The %check section is not present. Can you add it? 2. I think %{gem_instdir}/README.rdoc belongs in the -doc subpackage. 3. Both %{gem_instdir}/MIT-LICENSE and %{gem_instdir}/README.rdoc should be marked as %doc. 4. I don't see why you would need to ship %{gem_instdir}/%{gem_name}.gemspec, since you're already shipping %{gem_spec}. In my own gems I always delete this second copy of the gemspec (although I can't find anything in the Ruby guidelines about this.) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fENjln3CR1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review