[Bug 994474] Review Request: python-qrencode - Python wrapper for the qrencode library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=994474



--- Comment #11 from Michael Schwendt <bugs.michael@xxxxxxx> ---
And indeed, the %attr usage is enough distraction to miss a packaging mistake,
which I would spot easily under normal circumstances:

  %attr(0755, -, -) %{python_sitearch}/qrencode/qr_encode.so
  %{python_sitearch}/qrencode*

Make that

  %{python_sitearch}/qrencode/qr_encode.so
  %{python_sitearch}/qrencode*

and it becomes more obvious that it specifies some files multiple times
( http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles ), because

  %{python_sitearch}/qrencode*

also includes the file

  %{python_sitearch}/qrencode/qr_encode.so

(!)

The fedora-review tool finds it, of course:

> Issues:
> =======
> - Package does not contain duplicates in %files.
>   Note: warning: File listed twice: /usr/lib64/python2.7/site-
>   packages/qrencode/qr_encode.so
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

$ rpmls -p python-qrencode-1.01-1.fc20.x86_64.rpm 
drwxr-xr-x  /usr/lib64/python2.7/site-packages/qrencode
-rw-r--r--  /usr/lib64/python2.7/site-packages/qrencode-1.01-py2.7.egg-info
-rw-r--r--  /usr/lib64/python2.7/site-packages/qrencode/__init__.py
-rw-r--r--  /usr/lib64/python2.7/site-packages/qrencode/__init__.pyc
-rw-r--r--  /usr/lib64/python2.7/site-packages/qrencode/__init__.pyo
-rwxr-xr-x  /usr/lib64/python2.7/site-packages/qrencode/qr_encode.so

Several different solutions for the %files list would be possible.
When fixing the .so file permissions in %install, e.g. this single line:

  %{python_sitearch}/qrencode*

Or with explicitly listed .egg-info file:

  %{python_sitearch}/qrencode*.egg-info
  %{python_sitearch}/qrencode/

Or with explicitly listed dir and files entries:

  %{python_sitearch}/qrencode*.egg-info
  %dir %{python_sitearch}/qrencode
  %{python_sitearch}/qrencode/*.py*
  %{python_sitearch}/qrencode/*.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y7P53QMwBu&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]