https://bugzilla.redhat.com/show_bug.cgi?id=994474 Marcel Haerry <mh+fedora@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | --- Comment #12 from Marcel Haerry <mh+fedora@xxxxxxxx> --- (In reply to Michael Schwendt from comment #11) > And indeed, the %attr usage is enough distraction to miss a packaging > mistake, which I would spot easily under normal circumstances: > > %attr(0755, -, -) %{python_sitearch}/qrencode/qr_encode.so > %{python_sitearch}/qrencode* > > Make that > > %{python_sitearch}/qrencode/qr_encode.so > %{python_sitearch}/qrencode* > > and it becomes more obvious that it specifies some files multiple times > ( http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles ), > because > > %{python_sitearch}/qrencode* > > also includes the file > > %{python_sitearch}/qrencode/qr_encode.so > > (!) right. Thank you for your comments. I changed the spec file according your first recommendation and pushed the new SPEC file as well as the new srpm and 2 new test builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=5824366 http://koji.fedoraproject.org/koji/taskinfo?taskID=5824375 Also the review output looks good to me. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1WGtqezX9i&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review